Skip to content

AutoCrud in a flexbox does not use the full width on small screens #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Legioth opened this issue Mar 5, 2025 · 1 comment · May be fixed by #3425
Open

AutoCrud in a flexbox does not use the full width on small screens #3323

Legioth opened this issue Mar 5, 2025 · 1 comment · May be fixed by #3425
Labels
bug Something isn't working good first issue Good for newcomers hilla Issues related to Hilla Impact: Low Severity: Minor

Comments

@Legioth
Copy link
Member

Legioth commented Mar 5, 2025

Describe the bug

The grid section of AutoCrud shrinks rather than grows when it becomes so narrow that the form is hidden and instead opens as a modal popover.

Slightly wider browser window:
Image

Slightly narrower browser window:
Image

Expected-behavior

Expected that the grid fills the full available width in a narrow browser.

Reproduction

<section className="flex">
  <AutoCrud service={HelloWorldService} model={PersonModel} />
</section>

System Info

Hilla 24.7.0.beta1
Chrome 133

@rbrki07
Copy link
Contributor

rbrki07 commented Apr 17, 2025

A fix might be quite easily done with some additional CSS, but I wonder how you cover those kinds of changes with automated tests? Are there specific UI test suites I could check to make sure an additional flex: 1 at one point won't break the UI at any other point?

@rbrki07 rbrki07 linked a pull request Apr 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hilla Issues related to Hilla Impact: Low Severity: Minor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants