-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and improvements #208
Conversation
Also, I'd like to increase the required node version for this application to 14 or some other higher LTS version. Node.js 12 will be reaching end of life soon. |
Hiding the text in the option buttons if the screen | ||
width is not big enough | ||
*/ | ||
button span { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button#option-buttons span
?
To be more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll add this.
Sounds good to me! |
Ah my bad, i confused it with #209 |
I can't think of calling it anything else. I had previously planned to add a third option in that modal where users can download a PDF containing both of them. (Might add it in the future, the code is somewhere in my fork)
I'll try moving things around and see if something looks good. Edit:
Oh, alright. |
Also, could you unlink the issue this PR is linked to, It got linked automatically when when I mentioned it. It should be linked to #193. Thanks! |
GitHub isn't letting me 🤦♂️ |
Oh, I thought I didn't have permission to do it. Must be a GitHub bug. Edit: Yeah, it's not letting my remove the first one it linked for some reason. |
Hi @vatz88 I made quite a few changes in this PR but don't worry you don't have to look at the code, I'll list down the things I've changed below.
If you have any suggestions please let me know, I won't be merging this PR immediately (Edit: It looks like I don't have permission to merge my own PRs). There's still a tiny amount of cleaning left. I'll merge it after I resolve #169. I did this cleanup first so that everything would be more organised for the major changes I'll have to do to support different timetables.
This PR closes most of #193.