1723 new net p1 code review and test thortransactions package (#1881)

* feat: chaing gas unit handling and added unit tests

* fix: fixed gas handling

* fix: fixed gas used for Receipt class

* fix: updated gas price convertion for GetTxResponseJSON

* fix: removed EXP

* fix: renamed EXP unit test to a more comprehensive name and added verify

Author: GrandinLuc

packages/thorest/src/thor/transactions/Clause.ts

@@ -1,4 +1,4 @@
-import { Address, HexUInt, VET } from '@vechain/sdk-core';
+import { Address, HexUInt, Units, VET } from '@vechain/sdk-core';
 
 class Clause {
     readonly to?: Address;
@@ -10,7 +10,7 @@ class Clause {
             json.to !== undefined && json.to != null
                 ? Address.of(json.to)
                 : undefined;
-        this.value = VET.of(json.value);
+        this.value = VET.of(json.value, Units.wei);
         this.data = HexUInt.of(json.data);
     }
 

packages/thorest/tests/thor/transactions/RetrieveRawTransactionByIID.unit.test.ts

@@ -0,0 +1,47 @@
+import { describe, test } from '@jest/globals';
+import { TxId } from '@vechain/sdk-core';
+import {
+    type FetchHttpClient,
+    type GetRawTxResponseJSON,
+    RetrieveRawTransactionByID
+} from '../../../src';
+
+const mockHttpClient = <T>(response: T): FetchHttpClient => {
+    return {
+        get: jest.fn().mockImplementation(() => {
+            return {
+                json: jest.fn().mockImplementation(() => {
+                    return response;
+                })
+            };
+        })
+    } as unknown as FetchHttpClient;
+};
+
+/**
+ * VeChain transaction - unit
+ *
+ * @group unit/transaction
+ */
+describe('RetrieveRawTransactionByID unit tests', () => {
+    test('ok <- askTo', async () => {
+        const txId = TxId.of(
+            '0xb6b5b47a5eee8b14e5222ac1bb957c0bbdc3d489850b033e3e544d9ca0cef934'
+        );
+
+        const mockResponse = {
+            raw: '0xf8970184aabbccdd20f840df947d8bf18c7ce84b3e175b339c4ca93aed1dd4885501a69400000000000000000000000000000000000000000880de0b6b3a76400008028a0a8134669348e8a7ad34a64a193def01cc0d0f77935f134120ef507a87dcfe39da0046ae0acb1b9c47aadb38c2f0ce5789be81d194471378b14c53f3c6677f209c4',
+            meta: {
+                blockID:
+                    '0x0000000000000000000000000000000000000000000000000000000000000000',
+                blockNumber: 1,
+                blockTimestamp: 1000000
+            }
+        } satisfies GetRawTxResponseJSON;
+
+        const mockClient = mockHttpClient(mockResponse);
+        const response =
+            await RetrieveRawTransactionByID.of(txId).askTo(mockClient);
+        expect(response.response.toJSON()).toEqual(mockResponse);
+    });
+});

packages/thorest/tests/thor/transactions/RetrieveTransactionByIID.unit.test.ts

@@ -0,0 +1,67 @@
+import { describe, test } from '@jest/globals';
+import { TxId } from '@vechain/sdk-core';
+import {
+    type FetchHttpClient,
+    type GetTxResponseJSON,
+    RetrieveTransactionByID
+} from '../../../src';
+
+const mockHttpClient = <T>(response: T): FetchHttpClient => {
+    return {
+        get: jest.fn().mockImplementation(() => {
+            return {
+                json: jest.fn().mockImplementation(() => {
+                    return response;
+                })
+            };
+        })
+    } as unknown as FetchHttpClient;
+};
+
+/**
+ * VeChain transaction - unit
+ *
+ * @group unit/transaction
+ */
+describe('RetrieveTransactionByID unit tests', () => {
+    test('ok <- askTo', async () => {
+        const txId = TxId.of(
+            '0xb6b5b47a5eee8b14e5222ac1bb957c0bbdc3d489850b033e3e544d9ca0cef934'
+        );
+
+        const mockResponse = {
+            id: '0xb6b5b47a5eee8b14e5222ac1bb957c0bbdc3d489850b033e3e544d9ca0cef934',
+            chainTag: 39,
+            blockRef:
+                '0x0000000000000000000000000000000000000000000000000000000000000000',
+            expiration: 32,
+            clauses: [
+                {
+                    to: '0x7d8Bf18C7ce84B3e175B339C4cA93Aed1dD488Aa',
+                    // We are adding a leading zero to the value because of how VCDM's
+                    // Hex is parsing and because we need an even number of hex-digits in other places
+                    value: '0x05ec3db77eba739400',
+                    data: '0x'
+                }
+            ],
+            gasPriceCoef: 0,
+            gas: 21000,
+            origin: '0x7d8Bf18C7ce84B3e175B339C4cA93Aed1dD488Aa',
+            nonce: '0x12345678',
+            dependsOn: undefined,
+            delegator: null,
+            size: 128,
+            meta: {
+                blockID:
+                    '0x0000000000000000000000000000000000000000000000000000000000000000',
+                blockNumber: 1,
+                blockTimestamp: 1000000
+            }
+        } satisfies GetTxResponseJSON;
+
+        const mockClient = mockHttpClient(mockResponse);
+        const response =
+            await RetrieveTransactionByID.of(txId).askTo(mockClient);
+        expect(response.response.toJSON()).toEqual(mockResponse);
+    });
+});

packages/thorest/tests/thor/transactions/RetrieveTransactionReceipt.unit.test.ts

@@ -0,0 +1,62 @@
+import { describe, test } from '@jest/globals';
+import { TxId } from '@vechain/sdk-core';
+import {
+    type FetchHttpClient,
+    type GetTxReceiptResponseJSON,
+    RetrieveTransactionReceipt
+} from '../../../src';
+
+const mockHttpClient = <T>(response: T): FetchHttpClient => {
+    return {
+        get: jest.fn().mockImplementation(() => {
+            return {
+                json: jest.fn().mockImplementation(() => {
+                    return response;
+                })
+            };
+        })
+    } as unknown as FetchHttpClient;
+};
+
+/**
+ * VeChain transaction - unit
+ *
+ * @group unit/transaction
+ */
+describe('RetrieveTransactionReceipt unit tests', () => {
+    test('ok <- askTo', async () => {
+        const txId = TxId.of(
+            '0xb6b5b47a5eee8b14e5222ac1bb957c0bbdc3d489850b033e3e544d9ca0cef934'
+        );
+
+        const mockResponse = {
+            gasUsed: 2100,
+            gasPayer: '0x7d8Bf18C7ce84B3e175B339C4cA93Aed1dD488Aa',
+            paid: '0x1234567890',
+            reward: '0x0987654321',
+            meta: {
+                blockID:
+                    '0x0000000000000000000000000000000000000000000000000000000000000000',
+                blockNumber: 0,
+                blockTimestamp: 0,
+                txID: '0x0000000000000000000000000000000000000000000000000000000000000000',
+                txOrigin:
+                    '0x0000000000000000000000000000000000000000000000000000000000000000'
+            },
+            reverted: false,
+            outputs: [
+                {
+                    contractAddress:
+                        '0x0000000000000000000000000000000000000000',
+                    events: [],
+                    transfers: []
+                }
+            ]
+        } satisfies GetTxReceiptResponseJSON;
+
+        const mockClient = mockHttpClient(mockResponse);
+        const response =
+            await RetrieveTransactionReceipt.of(txId).askTo(mockClient);
+        expect(response.response.toJSON()).toEqual(mockResponse);
+    });
+});

packages/thorest/tests/thor/transactions/SendTransaction.unit.test.ts

@@ -0,0 +1,48 @@
+import { describe, test } from '@jest/globals';
+import { transferTransactionBody } from '../../../../network/tests/thor-client/transactions/fixture';
+import { TEST_ACCOUNTS } from '../../../../network/tests/fixture';
+import { HexUInt, Transaction } from '@vechain/sdk-core';
+import { type FetchHttpClient, SendTransaction, TXID } from '../../../src';
+
+const mockHttpClient = <T>(response: T): FetchHttpClient => {
+    return {
+        post: jest.fn().mockImplementation(() => {
+            return {
+                json: jest.fn().mockImplementation(() => {
+                    return response;
+                })
+            };
+        })
+    } as unknown as FetchHttpClient;
+};
+
+/**
+ * VeChain transaction - unit
+ *
+ * @group unit/transaction
+ */
+describe('SendTransaction solo tests', () => {
+    test('ok <- askTo', async () => {
+        const gasResult = {
+            totalGas: 21000,
+            reverted: false,
+            revertReasons: [],
+            vmErrors: []
+        };
+        const tx = Transaction.of({
+            ...transferTransactionBody,
+            gas: gasResult.totalGas,
+            nonce: 10000000
+        }).sign(
+            HexUInt.of(TEST_ACCOUNTS.TRANSACTION.TRANSACTION_SENDER.privateKey)
+                .bytes
+        ).encoded;
+        const response = await SendTransaction.of(tx).askTo(
+            mockHttpClient(new TXID({ id: '0x123' }))
+        );
+
+        expect(response.response.toJSON()).toEqual(
+            new TXID({ id: '0x123' }).toJSON()
+        );
+    });
+});