Skip to content

Commit cac47ff

Browse files
jszwedkojszwedko
authored
chore(ci): Remove vestigial commit status steps from regression workflow (#21784)
* chore(ci): Added needed `statuses` permission to regression workflow Now that we changed the default to readonly. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * drop steps instead Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
1 parent 6ac72ba commit cac47ff

File tree

1 file changed

+0
-149
lines changed

1 file changed

+0
-149
lines changed

‎.github/workflows/regression.yml

-149
Original file line numberDiff line numberDiff line change
@@ -373,19 +373,6 @@ jobs:
373373
- upload-baseline-image-to-ecr
374374
- upload-comparison-image-to-ecr
375375
steps:
376-
- name: Check status, in-progress
377-
env:
378-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
379-
run: |
380-
gh api \
381-
--method POST \
382-
-H "Accept: application/vnd.github+json" \
383-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
384-
-f state='pending' \
385-
-f description='Experiments submitted to the Regression Detection cluster.' \
386-
-f context='Regression Detection Suite / submission' \
387-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
388-
389376
- uses: actions/checkout@v4
390377
with:
391378
ref: ${{ needs.resolve-inputs.outputs.comparison-sha }}
@@ -447,47 +434,6 @@ jobs:
447434
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job cancel \
448435
--submission-metadata ${{ runner.temp }}/submission-metadata
449436
450-
- name: Check status, cancelled
451-
if: ${{ cancelled() }}
452-
env:
453-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
454-
run: |
455-
gh api \
456-
--method POST \
457-
-H "Accept: application/vnd.github+json" \
458-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
459-
-f state='failure' \
460-
-f description='Experiments submitted to the Regression Detection cluster cancelled.' \
461-
-f context='Regression Detection Suite / submission' \
462-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
463-
464-
- name: Check status, success
465-
env:
466-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
467-
run: |
468-
gh api \
469-
--method POST \
470-
-H "Accept: application/vnd.github+json" \
471-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
472-
-f state='success' \
473-
-f description='Experiments submitted to the Regression Detection cluster successfully.' \
474-
-f context='Regression Detection Suite / submission' \
475-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
476-
477-
- name: Check status, failure
478-
if: ${{ failure() }}
479-
env:
480-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
481-
run: |
482-
gh api \
483-
--method POST \
484-
-H "Accept: application/vnd.github+json" \
485-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
486-
-f state='success' \
487-
-f description='Experiments submitted to the Regression Detection Suite failed.' \
488-
-f context='Regression Detection Suite / submission' \
489-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
490-
491437
##
492438
## ANALYZE
493439
##
@@ -529,47 +475,6 @@ jobs:
529475
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job result \
530476
--submission-metadata ${{ runner.temp }}/submission-metadata
531477
532-
- name: Check status, cancelled
533-
if: ${{ cancelled() }}
534-
env:
535-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
536-
run: |
537-
gh api \
538-
--method POST \
539-
-H "Accept: application/vnd.github+json" \
540-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
541-
-f state='failure' \
542-
-f description='Analyze experimental results from Regression Detection Suite cancelled.' \
543-
-f context='Regression Detection Suite / detect-regression' \
544-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
545-
546-
- name: Check status, success
547-
env:
548-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
549-
run: |
550-
gh api \
551-
--method POST \
552-
-H "Accept: application/vnd.github+json" \
553-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
554-
-f state='success' \
555-
-f description='Analyze experimental results from Regression Detection Suite succeeded.' \
556-
-f context='Regression Detection Suite / detect-regression' \
557-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
558-
559-
- name: Check status, failure
560-
if: ${{ failure() }}
561-
env:
562-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
563-
run: |
564-
gh api \
565-
--method POST \
566-
-H "Accept: application/vnd.github+json" \
567-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
568-
-f state='failure' \
569-
-f description='Analyze experimental results from Regression Detection Suite failed.' \
570-
-f context='Regression Detection Suite / detect-regression' \
571-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
572-
573478
analyze-experiment:
574479
name: Download regression analysis & upload report
575480
runs-on: ubuntu-22.04
@@ -579,19 +484,6 @@ jobs:
579484
- submit-job
580485
- resolve-inputs
581486
steps:
582-
- name: Check status, in-progress
583-
env:
584-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
585-
run: |
586-
gh api \
587-
--method POST \
588-
-H "Accept: application/vnd.github+json" \
589-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
590-
-f state='pending' \
591-
-f description='Analyze experimental results from Regression Detection Suite.' \
592-
-f context='Regression Detection Suite / analyze-experiment' \
593-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
594-
595487
- uses: actions/checkout@v4
596488
with:
597489
ref: ${{ needs.resolve-inputs.outputs.comparison-sha }}
@@ -635,47 +527,6 @@ jobs:
635527
name: capture-artifacts
636528
path: ${{ runner.temp }}/outputs/*
637529

638-
- name: Check status, cancelled
639-
if: ${{ cancelled() }}
640-
env:
641-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
642-
run: |
643-
gh api \
644-
--method POST \
645-
-H "Accept: application/vnd.github+json" \
646-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
647-
-f state='failure' \
648-
-f description='Analyze experimental results from Regression Detection Suite cancelled.' \
649-
-f context='Regression Detection Suite / analyze-experiment' \
650-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
651-
652-
- name: Check status, success
653-
env:
654-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
655-
run: |
656-
gh api \
657-
--method POST \
658-
-H "Accept: application/vnd.github+json" \
659-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
660-
-f state='success' \
661-
-f description='Analyze experimental results from Regression Detection Suite succeeded.' \
662-
-f context='Regression Detection Suite / analyze-experiment' \
663-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
664-
665-
- name: Check status, failure
666-
if: ${{ failure() }}
667-
env:
668-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
669-
run: |
670-
gh api \
671-
--method POST \
672-
-H "Accept: application/vnd.github+json" \
673-
/repos/${{ github.repository }}/statuses/${{ needs.resolve-inputs.outputs.comparison-sha }} \
674-
-f state='failure' \
675-
-f description='Analyze experimental results from Regression Detection Suite failed.' \
676-
-f context='Regression Detection Suite / analyze-experiment' \
677-
-f target_url=${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
678-
679530
regression-detection-suite:
680531
name: Set final result
681532
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)