Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus_scrape source: add compatibility with HTTP Service Discovery #22102

Closed
jhbigler opened this issue Jan 1, 2025 · 1 comment
Closed
Labels
type: feature A value-adding code addition that introduce new functionality.

Comments

@jhbigler
Copy link

jhbigler commented Jan 1, 2025

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Normally, prometheus discovers services with a local file - however it can also use an http-based service discovery, which returns services and labels in JSON format. It seems like vector's prometheus_scrape source expects the entire service definition in its config file - it would be nice if it had the ability to use the HTTP SD.

My use case: Zeek's telemetry framework recommends using its service discovery endpoint (it can collect all of the metrics from all nodes, but that is costly on Zeek). Because zeek can be using many workers with many endpoints to collect metrics from, it's hard to know ahead of time all of the endpoints to collect metrics from. As such, I'd like to use a HTTP SD.

Attempted Solutions

No response

Proposal

Perhaps a new parameter like http_service_discovery_endpoint?

References

No response

Version

No response

@jhbigler jhbigler added the type: feature A value-adding code addition that introduce new functionality. label Jan 1, 2025
@jszwedko
Copy link
Member

jszwedko commented Jan 2, 2025

Hey @jhbigler ! I think this is a duplicate of #2303 so I'll close this one, but feel free to follow along or add additional details to the other.

@jszwedko jszwedko closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants