Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expression checker): prevent identifier warnings for closures #1217

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(expression checker): prevent identifier warnings for closures #1217

wants to merge 2 commits into from

Conversation

pront
Copy link
Member

@pront pront commented Jan 9, 2025 •
edited
Loading

Summary

Do not warn for unused variable inside closures. There are a lot details on the linked issues.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Added unit test.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

Ref: #1216

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 9, 2025
@pront pront requested a review from jszwedko January 9, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko Awaiting requested review from jszwedko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused checker reports variable used in if-condition inside for_each block as unused
1 participant
@pront