-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduled tasks #3463
Merged
Merged
Scheduled tasks #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
It was automatically removing the `standalone` property from components, breaking the build.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #1425
This PR implements a new mechanism and set of APIs which allows us to define scheduled tasks directly in Vendure and Vendure Plugins.
It solves the fundamental problem of solutions like
@nestjs/schedule
by guaranteeing that a given task will only execute exactly once for a given schedule period, even if we are running in a horizontally-scaled environment with multiple server and worker instances.It does this by using a shared locking mechanism. By default this is done using a new database table, which allows each task to be tracked and locked across instances.
The API looks like this:
Breaking changes
We export a new
DefaultSchedulerPlugin
which includes a new database entity, so when adding this to a project, a database migration will be required.