Clean Code, add get,post and put functionality

Author: vgalvoso

api/items.php

@@ -1,4 +1,7 @@
 <?php
+header("Access-Control-Allow-Origin: *");
+header("Content-Type: application/json; charset=utf-8");
+$sql = new Sql();
 $query = "SELECT * FROM items";
 $items = $sql->getItems($query);
 exit(json_encode($items));

index.php

@@ -1,7 +1,7 @@
 <?php
   session_start();
-  require_once "lib/sql.php";
-  require_once "lib/helper.php";
+  require_once "lib/Sql.php";
+  require_once "lib/Helper.php";
 
-  route("/","api/items");
+  get("api/items","items");
 ?>

lib/database-sample.php renamed to lib/Database-sample.php

@@ -1,12 +1,10 @@
 <?php
-//rename to database.php
-$db = array(
-
-    "default" => array(
+$db = [
+    "default" => [
         "server" => "localhost",
         "user" => "root",
         "pass" => "",
-        "dbname" => "db",
+        "dbname" => "pos",
         "driver" => "mysql"
-    )
-);
+    ]
+];

lib/helper.php

@@ -1,47 +1,77 @@
 <?php
-//get uri
-$url = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] === 'on' ? "https" : "http") .
-"://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]";
-$path = parse_url($url, PHP_URL_PATH);
-//remove string from last "/" to first character
-$path = trim(ltrim(strchr($path,"/"),"/"));
-$path = ltrim(substr($path,strposX($path,"/",1)),"/");
-
-$sql = new Sql();
-
-function strposX($haystack, $needle, $number = 0)
-{
-    return strpos($haystack, $needle,
-        $number > 1 ?
-        strposX($haystack, $needle, $number - 1) + strlen($needle) : 0
-    );
-}
+$path = $_SERVER['REQUEST_URI'];
+//get $path except first "/"
+$path = substr($path, 1);
+//remove string from start to second "/"
+$path = substr($path, strpos($path, "/") + 1);
+
+$method = $_SERVER['REQUEST_METHOD'];
 
-function api($api=null){
+function api($routeName,$api,$method){
     global $path;
-    if($api!=null) $path = $api;
-    if(isset($_POST)) extract($_POST);
-    if(isset($_GET)) extract($_GET);
+    $route = $routeName;
+    //for request with parameters in uri 
+    if(strpos($routeName,"{")){   
+        //get routeName without parameters 
+        $tempRoute = substr($routeName,0,strpos($routeName,"{")+1);
+        $route = substr($tempRoute,0,strlen($tempRoute)-1);
+        //get param keys
+        $paramKeys = substr($routeName,strpos($routeName,"{")+1);
+        $paramKeys = substr($paramKeys,0,strlen($paramKeys)-1);
+        $paramKeys = explode(",",$paramKeys);
+
+        
+        //check if routename exists in request uri
+        if(str_contains($path,$route)){
+            $pos = strrpos($route,"/");
+            $paramValues = substr($path,$pos+1);
+            $paramValues = explode("/",$paramValues);
+            if(count($paramKeys) != count($paramValues))
+                notFound();
+            $params = array_combine($paramKeys,$paramValues);
+            $path = substr($path,0,strlen($route)-1);
+            $route = substr($tempRoute,0,strlen($tempRoute)-2);
+            extract($params);
+        }
+    }
+    if($route != $path)
+        return;
+    $path = $api;
+    extract($method);
     if(!file_exists("api/$path.php")){
         if(!file_exists("api/$path/index.php")){   
-            header("HTTP/1.1 404 Not Found");
-            exit("URL not found");
+            notFound();
         }
         $path = $path."/index";
     }
-    global $sql;
-    header('Cache-Control: max-age=86400');
-    header("Access-Control-Allow-Origin: *");
-    header("Content-Type: application/json; charset=utf-8");
+    
     include "api/$path.php";
+    exit();
 }
 
-function route($routeName,$api){
-    global $path;
-    if($routeName==$path){
-      api($api);
-      exit();
-    }
-  }
+function post($routeName,$api){
+    global $method;
+    if($method != "POST") return;
+    api($routeName,$api,$_POST);
+}
+
+function get($routeName,$api){
+    global $method;
+    if($method != "GET") return;
+    api($routeName,$api,$_GET);
+}
+
+function put($routeName,$api){
+    global $method;
+    if($method != "PUT") return;
+    $_PUT = json_decode(file_get_contents('php://input'),true);
+    api($routeName,$api,$_PUT);
+}
+
+
+function notFound(){
+    header("HTTP/1.1 404 Not Found");
+    exit("URL not found");
+}
 
 

lib/sql.php

@@ -20,7 +20,7 @@ class Sql{
      * @author Van
      */
     public function __construct($dbase="default",$server="",$user="",$pass="",$dbname="",$driver=""){
-        require "database.php";
+        require "Database.php";
         if($dbase != null){
             $server = $db[$dbase]["server"];
             $user = $db[$dbase]["user"];
@@ -30,9 +30,9 @@ public function __construct($dbase="default",$server="",$user="",$pass="",$dbnam
         }
         try{
             $this->conn = new PDO("$driver:host=$server;dbname=$dbname;",$user,$pass,
-                array(PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION));
+                [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
         }catch(PDOException $e){
-            $this->error = $e->getMessage();
+            exit($this->error = $e->getMessage());
         }
     }
 
@@ -81,7 +81,7 @@ public function getItems($query,$inputs=null){
         try{
             $stmt = $this->conn->prepare($query);
             $stmt->execute($inputs);
-            return $stmt->fetchAll(PDO::FETCH_ASSOC);
+            return $stmt->fetchAll(PDO::FETCH_OBJ);
         }catch(PDOException $e){
             $this->error = $e->getMessage();
             return false;