Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering doesn't seem to do anything #14

Open
KatyMunson opened this issue Feb 13, 2025 · 2 comments
Open

Filtering doesn't seem to do anything #14

KatyMunson opened this issue Feb 13, 2025 · 2 comments

Comments

@KatyMunson
Copy link

The -f parameter doesn't seem to do anything.

(base) kmiyamot@liger$ rdeval --version
rdeval v0.0.5
Giulio Formenti giulio.formenti@gmail.com
(base) kmiyamot@liger$ rdeval myONT.rd
+++Read summary+++:
# reads: 17267657
Total read length: 119916190443
Average read length: 6944.55
Read N50: 32409
Smallest read length: 1
Largest read length: 1731095
Coverage: inf
GC content %: 40.43
Base composition (A:C:T:G): 35654976733:24053725773:35779931816:24427556121
Average per base quality: 18.38
(base) kmiyamot@liger$ rdeval myONT.rd --filter 'q>20 & l>10'
+++Read summary+++:
# reads: 17267657
Total read length: 119916190443
Average read length: 6944.55
Read N50: 32409
Smallest read length: 1
Largest read length: 1731095
Coverage: inf
GC content %: 40.43
Base composition (A:C:T:G): 35654976733:24053725773:35779931816:24427556121
Average per base quality: 18.38
@gf777
Copy link
Contributor

gf777 commented Feb 14, 2025

Hi @KatyMunson again many thanks for the useful feedback!
Good catch, so on .rd files specifically this combination doesn't filter. You can filter the per-read output of .rd files as in e.g. rdeval myONT.rd --filter 'q>20 & l>10' -qa
We will fix it with the next release. Cheers

@KatyMunson
Copy link
Author

Thanks Guilio! Would love to see output files also reflect any filtering done (e.g. rdeval myONT.rd --filter 'q>20 & l>10' -o filtered.rd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants