Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper not detected popup #136

Closed
Roger-luo opened this issue Dec 4, 2022 · 4 comments
Closed

paper not detected popup #136

Roger-luo opened this issue Dec 4, 2022 · 4 comments

Comments

@Roger-luo
Copy link

Describe the bug
Nothing is shown in popup for https://arxiv.org/pdf/math/0502036.pdf

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://arxiv.org/pdf/math/0502036.pdf
  2. Click on the plugin button
  3. Nothing is shown

Expected behavior
Whatever works for other paper

Screenshots
image

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
@vict0rsch
Copy link
Owner

Hi!

Thank you for reporting the bug.

It's not surprising since PaperMemory expects arxiv papers to match the pattern: arxiv.org/(abs|pdf)/\d{4}\.\d{4,5}(\.pdf)?

I'll update the code in the next version to match such papers, I was not aware of such urls existing on arxiv 😅

@Roger-luo
Copy link
Author

Roger-luo commented Dec 5, 2022

Thanks for the quick response. This is a very nice package btw.

Yeah I notice that some old papers are not following the new URL rules. It works well until I start reading these old papers recently 😛

@vict0rsch
Copy link
Owner

Thank you!

I'll keep you posted but I expect not before Jan

@vict0rsch
Copy link
Owner

addressed in #139, will be in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants