Skip to content

Commit dab7f61

Browse files
bottlerfacebook-github-bot
authored andcommitted
CI updates
Summary: Document existence of nightly build. Fix some mistakes in windows-related CI code (not running yet). Reviewed By: nikhilaravi Differential Revision: D20030293 fbshipit-source-id: 2199ea7c6d34e881aa5641726feb6bfc20337ce3
1 parent c2a0a3e commit dab7f61

File tree

6 files changed

+16
-19
lines changed

6 files changed

+16
-19
lines changed

.circleci/config.in.yml

-4
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,6 @@ workflows:
188188
jobs:
189189
- main
190190
{{workflows()}}
191-
- binary_linux_conda:
192-
cu_version: cu101
193-
name: binary_linux_conda_py3.7_cu101
194-
python_version: '3.7'
195191
- binary_linux_conda_cuda:
196192
name: testrun_conda_cuda_py3.7_cu100
197193
python_version: "3.7"

.circleci/config.yml

+1-5
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,8 @@ workflows:
247247
name: binary_linux_conda_py3.8_cu101
248248
python_version: '3.8'
249249
pytorch_version: '1.4'
250-
- binary_linux_conda:
251-
cu_version: cu101
252-
name: binary_linux_conda_py3.7_cu101
253-
python_version: '3.7'
254250
- binary_linux_conda_cuda:
255251
name: testrun_conda_cuda_py3.7_cu100
256252
python_version: "3.7"
257253
pytorch_version: "1.4"
258-
cu_version: "cu100"
254+
cu_version: "cu100"

.circleci/regenerate.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,10 @@ def indent(indentation, data_list):
112112
if __name__ == "__main__":
113113
d = os.path.dirname(__file__)
114114
env = jinja2.Environment(
115-
loader=jinja2.FileSystemLoader(d), lstrip_blocks=True, autoescape=False
115+
loader=jinja2.FileSystemLoader(d),
116+
lstrip_blocks=True,
117+
autoescape=False,
118+
keep_trailing_newline=True,
116119
)
117120

118121
with open(os.path.join(d, "config.yml"), "w") as f:

INSTALL.md

+6
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ After installing the above dependencies, run one of the following commands:
5555
conda install pytorch3d -c pytorch3d
5656
```
5757

58+
Or, to install a nightly (non-official, alpha) build:
59+
```
60+
# Anaconda Cloud
61+
conda install pytorch3d -c pytorch3d-nightly
62+
```
63+
5864
### 2. Install from GitHub
5965
```
6066
pip install 'git+https://github.com/facebookresearch/pytorch3d.git'

packaging/conda/build_pytorch3d.sh

+4-8
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ if [[ ! -d "$pytorch3d_rootdir" ]]; then
7272
rm -rf "$pytorch3d_rootdir"
7373
git clone SOURCE_DIR/../.. "$pytorch3d_rootdir"
7474

75-
# pushd "$vision_rootdir"
76-
# git checkout $PYTORCH_BRANCH
77-
# popd
7875
fi
7976

8077
cd "$SOURCE_DIR"
@@ -94,7 +91,6 @@ ANACONDA_USER=pytorch-nightly
9491
conda config --set anaconda_upload no
9592

9693

97-
export TORCHVISION_PACKAGE_SUFFIX=""
9894
if [[ "$desired_cuda" == 'cpu' ]]; then
9995
export CONDA_CUDATOOLKIT_CONSTRAINT=""
10096
export CONDA_CPUONLY_FEATURE="- cpuonly # [not osx]"
@@ -164,7 +160,7 @@ for py_ver in "${DESIRED_PYTHON[@]}"; do
164160
--output-folder "$output_folder" \
165161
../$VSTOOLCHAIN_PACKAGE
166162

167-
cp ../$VSTOOLCHAIN_PACKAGE/conda_build_config.yaml ../torchvision/conda_build_config.yaml
163+
cp ../$VSTOOLCHAIN_PACKAGE/conda_build_config.yaml ../pytorch3d/conda_build_config.yaml
168164

169165
conda config --set anaconda_upload no
170166
echo "Calling conda-build at $(date)"
@@ -182,7 +178,7 @@ for py_ver in "${DESIRED_PYTHON[@]}"; do
182178
--output-folder "$output_folder" \
183179
--no-verify \
184180
--no-test \
185-
../torchvision
181+
../pytorch3d
186182
else
187183
time CMAKE_ARGS=${CMAKE_ARGS[@]} \
188184
BUILD_VERSION="$PYTORCH3D_BUILD_VERSION" \
@@ -196,13 +192,13 @@ for py_ver in "${DESIRED_PYTHON[@]}"; do
196192
--output-folder "$output_folder" \
197193
--no-verify \
198194
--no-test \
199-
../torchvision
195+
../pytorch3d
200196
fi
201197
echo "Finished conda-build at $(date)"
202198

203199
# Extract the package for testing
204200
ls -lah "$output_folder"
205-
built_package="$(find $output_folder/ -name '*torchvision*.tar.bz2')"
201+
built_package="$(find $output_folder/ -name '*pytorch3d*.tar.bz2')"
206202

207203
# Copy the built package to the host machine for persistence before testing
208204
if [[ -n "$PYTORCH_FINAL_PACKAGE_DIR" ]]; then

packaging/pkg_helpers.bash

+1-1
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,6 @@ setup_visual_studio_constraint() {
260260
export VSDEVCMD_ARGS=''
261261
# shellcheck disable=SC2086
262262
conda build $CONDA_CHANNEL_FLAGS --no-anaconda-upload packaging/$VSTOOLCHAIN_PACKAGE
263-
cp packaging/$VSTOOLCHAIN_PACKAGE/conda_build_config.yaml packaging/torchvision/conda_build_config.yaml
263+
cp packaging/$VSTOOLCHAIN_PACKAGE/conda_build_config.yaml packaging/pytorch3d/conda_build_config.yaml
264264
fi
265265
}

0 commit comments

Comments
 (0)