Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests #6

Open
Luflosi opened this issue May 4, 2021 · 4 comments
Open

Failing tests #6

Luflosi opened this issue May 4, 2021 · 4 comments

Comments

@Luflosi
Copy link

Luflosi commented May 4, 2021

The tests are failing in Travis-CI and on my local machine. On my local machine they seem to hang indefinitely but I'm not sure if the two failures are related. I'd like to package this library in nixpkgs and would feel more comfortable that the packaged version works correctly if the tests succeeded.
Please consider fixing the tests.

@Apteryks
Copy link

I also experience a hang in the test suite, using GNU Guix:

starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
running egg_info
writing wsgiprox.egg-info/PKG-INFO
writing dependency_links to wsgiprox.egg-info/dependency_links.txt
writing entry points to wsgiprox.egg-info/entry_points.txt
writing requirements to wsgiprox.egg-info/requires.txt
writing top-level names to wsgiprox.egg-info/top_level.txt
reading manifest file 'wsgiprox.egg-info/SOURCES.txt'
writing manifest file 'wsgiprox.egg-info/SOURCES.txt'
running build_ext
============================= test session starts ==============================
platform linux -- Python 3.8.2, pytest-5.3.5, py-1.8.1, pluggy-0.13.1 -- /gnu/store/f8s95qc6dfhl0r45m70hczw5zip0xjxq-python-wrapper-3.8.2/bin/python
cachedir: .pytest_cache
rootdir: /tmp/guix-build-python-wsgiprox-1.5.2.drv-0/wsgiprox-1.5.2
plugins: cov-2.8.1
collecting ... collected 79 items

test/test_wsgiprox.py::Test_gevent_WSGIProx::test_in_mem_ca PASSED       [  1%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_non_chunked[http] PASSED [  2%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_non_chunked[https] FAILED [  3%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_non_chunked_custom_port[http] PASSED [  5%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_non_chunked_custom_port[https] FAILED [  6%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_non_chunked_ip_port[http] PASSED [  7%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_non_chunked_ip_port[https] FAILED [  8%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_with_sni PASSED        [ 10%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_chunked[http] PASSED   [ 11%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_chunked[https] FAILED  [ 12%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_stream_data_chunked[http] PASSED [ 13%]
test/test_wsgiprox.py::Test_gevent_WSGIProx::test_stream_data_chunked[https] FAILED [ 15%]

@Luflosi
Copy link
Author

Luflosi commented Sep 22, 2021

I found a commit of an old PR in Nixpkgs that suggests that some tests would hang on network access for some reason:

Don't provide uwsgi to skip tests that would hang on network access.

I haven't investigated any further.

@fabaff
Copy link

fabaff commented Sep 22, 2021

At first glance it look like that *[https] tests fail...

@Apteryks
Copy link

Then it's probably just that the tests require proper networking that the build chroot on Nix/Guix doesn't accommodate. It'd be neat if the test suite could be told to skip network-related tests, or even do it by itself by some auto-detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants