-
-
Notifications
You must be signed in to change notification settings - Fork 116
Rename descriptionEditable
to custom_description
with backwards compatibility
#275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
descriptionEditable
to description_overwrite
with backwards compatibilitydescriptionEditable
to custom_description
with backwards compatibility
wei
added a commit
that referenced
this issue
Dec 19, 2024
Fixes #275 Rename `descriptionEditable` to `custom_description` with backwards compatibility. * Rename `descriptionEditable` to `custom_description` in `common/types/queryType.ts`. * Rename `descriptionEditable` to `custom_description` in `src/components/configuration/config.tsx`. * Add backwards compatibility check for `descriptionEditable` in `src/components/configuration/config.tsx`. * Rename `descriptionEditable` to `custom_description` in `common/configHelper.ts`. * Add backwards compatibility check for `descriptionEditable` in `common/configHelper.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/wei/socialify/issues/275?shareId=XXXX-XXXX-XXXX-XXXX).
wei
added a commit
that referenced
this issue
Dec 19, 2024
Fixes #275 Rename `descriptionEditable` to `custom_description` with backwards compatibility. * Rename `descriptionEditable` to `custom_description` in `common/types/queryType.ts`. * Rename `descriptionEditable` to `custom_description` in `src/components/configuration/config.tsx`. * Add backwards compatibility check for `descriptionEditable` in `src/components/configuration/config.tsx`. * Rename `descriptionEditable` to `custom_description` in `common/configHelper.ts`. * Add backwards compatibility check for `descriptionEditable` in `common/configHelper.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/wei/socialify/issues/275?shareId=XXXX-XXXX-XXXX-XXXX).
wei
added a commit
that referenced
this issue
Dec 19, 2024
Fixes #275 Rename `descriptionEditable` to `custom_description` with backwards compatibility. * Rename `descriptionEditable` to `custom_description` in `common/types/queryType.ts`. * Rename `descriptionEditable` to `custom_description` in `src/components/configuration/config.tsx`. * Add backwards compatibility check for `descriptionEditable` in `src/components/configuration/config.tsx`. * Rename `descriptionEditable` to `custom_description` in `common/configHelper.ts`. * Add backwards compatibility check for `descriptionEditable` in `common/configHelper.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/wei/socialify/issues/275?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
${key}Editable
tocustom_${key}
to prettify url as snake_case is preferred over camelCase in urls, such thatdescriptionEditable
tocustom_description
.${key}Editable
will still be an alias of the newcustom_${key}
, and things likedescriptionEditable
will still function as normal.custom_description
, Perhaps we can rename all variables to much shorter url parameters likei=1&f=1&d=1&do=Description%20Overwrite&t=Dark
socialify/common/types/queryType.ts
Line 14 in 5e8f2dc
socialify/src/components/configuration/config.tsx
Lines 102 to 109 in 5e8f2dc
This will come handy when adding language override too (#69)
The text was updated successfully, but these errors were encountered: