[Bug]: BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 #1223

wills106 · 2025-01-16T07:33:54Z

Describe the bug

Warning in log for BinaryPayloadDecoder is deprecated and will be removed in v3.9.0

Integration Version

2025.01.8

Homeassistant core version

2025.1.2

Inverter brand

All

Plugin used

plugin_solax.py

Serial prefix

N/A

Inverter firmware versions

N/A

Connection Method

N/A

Dongle firmware

N/A

Detailed Error Log

BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 ! Please use "client.convert_from_registers()" or "client.convert_to_registers" See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"

Additional context

I have raised this to try and reduce multiple Issues raised for the same warning.

Please don't spam this Issue saying you have the same error, as everyone will have this warning.

PSMGoossens · 2025-01-16T19:43:46Z

It seems that that the deprecation is no longer the case, but it's strange that it's popping up
https://github.com/pymodbus-dev/pymodbus/releases/tag/v3.8.3
Anyway it's good that it is removed, because otherwise it means a bigger rewrite, since the new "solution" is less flexible and doesn't support some key features such as ordering

wills106 · 2025-01-16T19:52:26Z

I'll keep track of pyModbus in case we do need to make the change, although there seems to be little examples of the changes required other than the very basic ones.

PSMGoossens · 2025-01-16T19:56:32Z

Yeah I agree,
But it seems that we can only convert one datatype at the same and "skip" functionality is not there, and no support for ordering of int32.
See also discussion at pyModbus: pymodbus-dev/pymodbus#2456

smartminjos · 2025-01-17T08:02:03Z

same issue here ..... if you need any logs, let me know ...

MrRickwi · 2025-01-18T10:10:58Z

Same here, log is flooded:

Logger: pymodbus.logging
Quelle: custom_components/solax_modbus/init.py:771
Integration: SolaX Inverter Modbus (Dokumentation, Probleme)
Erstmals aufgetreten: 17. Januar 2025 um 06:27:19 (48216 Vorkommnisse)
Zuletzt protokolliert: 11:09:20

BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 ! Please use "client.convert_from_registers()" or "client.convert_to_registers" See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"

PSMGoossens · 2025-01-18T12:21:29Z

Hi @wills106
I think we have a few options to solve this issue, I would like your opinion in this matter:
The operations are:

Rewrite the logic of fetchting the data. I think it's not performance optimal, but that is what they are using in the "solar" example at pyModbus, solar example
We could bring the payload.py from pyModbus to the application and support it ourself
We could write our own code to do the encoding / decoding.
Any other libs available?

I would prefer option 2 for now, brings the least risk and I don't think we need to maintain it a lot.

flopp999 · 2025-01-22T19:36:45Z

I don't know but maybe this can help you.
I have an Growatt MID 15KTL3-XH.
I tried and this code is working, at least for Growatt.
I didn't try those lines in Solax integration but I ran those lines by themself in a .py file

from pymodbus.client.mixin import ModbusClientMixin
registers = [19071, 20016, 17462, 17457, 12874]
serial=ModbusClientMixin.convert_from_registers(registers, data_type=ModbusClientMixin.DATATYPE.STRING)
print(serial)

will give output
N0D6D12J

link to classmethod
https://github.com/pymodbus-dev/pymodbus/blob/f7271cdf52770c0fb14d165ed35c3bc13fe7ae7e/pymodbus/client/mixin.py#L697

honekr · 2025-01-24T08:51:36Z

Same issue:

Tato chyba pochází z vlastní integrace.

Logger: pymodbus.logging
Zdroj: custom_components/solax_modbus/__init__.py:771
integrace: SolaX Inverter Modbus (dokumentace, problémy)
První výskyt: 08:45:11 (1764 výskyty)
Naposledy logováno: 09:48:02

BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 ! Please use "client.convert_from_registers()" or "client.convert_to_registers" See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"

PSMGoossens · 2025-01-25T11:23:07Z

I've created a PR where payload.py is brought to the application and the deprecration message is removed #1232

steps56 · 2025-01-27T00:12:24Z

I've created a PR where payload.py is brought to the application and the deprecration message is removed #1232

Thanks.
Used the latest integration zip
https://github.com/wills106/homeassistant-solax-modbus/archive/refs/heads/main.zip
with the added payload file and no errors spamming HA any more.
Well done 👌.

steps56 · 2025-01-28T10:31:02Z

Dieser Fehler stammt von einer benutzerdefinierten Integration

Logger: pymodbus.logging
Quelle: custom_components/old_solax_modbus/init.py:771
Integration: old_solax_modbus
Erstmals aufgetreten: 11:28:42 (4 Vorkommnisse)
Zuletzt protokolliert: 11:28:43

BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 ! Please use "client.convert_from_registers()" or "client.convert_to_registers" See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"

Sadly its back again after HA Update today...😪
If its possible, it should be fixed permanently to avoid future error spamming at each new HA core a. s. o. Update.
Thanks in advance.

Edit/Update:
The HA core Update crabbed all folders at costom components... and as I renamed the original one to "old_...." for safety if the workaround made by PSMGoossens (thanks a lot) wouldn't have worked.
Now after deleting the "old_..." and a HA start, all error spam has gone again gladly.
Hope this will survive the newt few HA core updates too...

wills106 · 2025-01-30T07:40:35Z

Just released 2025.01.9 with the change.

~~Looks like reading groups of registers will return in the new version~~ pymodbus-dev/pymodbus#2525 (comment)

Edit: It's been abandoned.

smartminjos · 2025-01-30T09:24:13Z

work like a charm ! thanks

wills106 · 2025-01-30T13:39:49Z

~~Looks like reading groups of registers will return in the new version~~ pymodbus-dev/pymodbus#2525 (comment)

Edit: It's been abandoned.

Probably need to look at how many separate reads would be needed with the new method. Unless we can string together the convert calls?

Or just stick with payload decoder being in this Integration.

PSMGoossens · 2025-02-04T19:29:08Z

Probably need to look at how many separate reads would be needed with the new method. Unless we can string together the convert calls?

Or just stick with payload decoder being in this Integration.

Calling the separate registers will be a massive overhead, so I think for now we should keep this solution
@wills106 Could you close this issue?

wills106 · 2025-02-04T20:03:25Z

Calling the separate registers will be a massive overhead

I agree and don't fancy going that route unless we have too.

hubertozog · 2025-02-19T09:14:01Z

@wills106 Unfortunately looks like problem appeared again. Or its some issue on my side?

steps56 · 2025-02-19T09:35:07Z

@wills106 Unfortunately looks like problem appeared again. Or its some issue on my side?

... and an other one, those spikes at many values from time to time.
Mentionend at a separate thread, but never answered if been under investigation by wills106 😪.

Now, many stuck at 2025.01.6 Modbus Integration to avoid spikes and misfunction of newer versions sadly 🤷🏼‍♂️.

wills106 · 2025-02-20T10:27:45Z

I have noticed you get the warning on restarting HA. But you only get it the once and not 10,000 times.

steps56 · 2025-02-20T11:01:09Z

I have noticed you get the warning on restarting HA. But you only get it the once and not 10,000 times.

Yes, this is right.

hubertozog · 2025-02-20T11:08:41Z

In my case i got 12k times till last restart. So maybe somthing on my side, but what?

2025-02-20 12:07:14.600 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:14.981 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:15.047 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:15.451 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:15.834 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:15.901 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:29.602 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:29.985 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:30.063 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:30.471 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:30.853 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:30.919 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:44.614 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:44.996 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:45.062 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !
Please use "client.convert_from_registers()" or "client.convert_to_registers"
See documentation: "https://pymodbus.readthedocs.io/en/latest/source/client.html#pymodbus.client.mixin.ModbusClientMixin.convert_from_registers"
2025-02-20 12:07:45.464 WARNING (MainThread) [pymodbus.logging] BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 !

wills106 · 2025-02-23T09:06:29Z

In my case i got 12k times till last restart. So maybe somthing on my side, but what?

What version of the Integration are you using?

hubertozog · 2025-02-23T10:33:29Z

Right now 2025.02.1.

wills106 · 2025-02-23T18:27:02Z

Reopening it for now, although it's not a major issue.

It only writes to the log once per HA restart.

hubertozog · 2025-02-24T05:32:02Z

@wills106 In my case its spaming errors all the time, right now 9k times

PSMGoossens · 2025-03-09T08:30:09Z

Removed the left overs in all plugins via PR #1274

steps56 · 2025-03-09T09:35:13Z

Is there a new Beta or ? out now containing your changes?
Can't find any now ...
Thanks for explaining please now.

wills106 · 2025-03-12T17:55:06Z

Just released 2025.03.1 with the changes.

wills106 added bug Something isn't working solax labels Jan 16, 2025

wills106 self-assigned this Jan 16, 2025

wills106 added non solax non solax growatt sofar solis labels Jan 16, 2025

wills106 closed this as completed Feb 4, 2025

wills106 mentioned this issue Feb 23, 2025

[Bug]: pymodbus 3.9.0 - BinaryPayloadDecoder #1261

Closed

wills106 reopened this Feb 23, 2025

wills106 mentioned this issue Feb 25, 2025

[Bug]: "ZCS Azzurro inverter reporting spikes in consumption/battery/production values that revolve around the magic 65535 integer #1229

Closed

PSMGoossens mentioned this issue Mar 9, 2025

Removed last deprecation message in plugins #1274

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 #1223

[Bug]: BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 #1223

wills106 commented Jan 16, 2025

PSMGoossens commented Jan 16, 2025

wills106 commented Jan 16, 2025

PSMGoossens commented Jan 16, 2025

smartminjos commented Jan 17, 2025

MrRickwi commented Jan 18, 2025

PSMGoossens commented Jan 18, 2025

flopp999 commented Jan 22, 2025 •

edited

Loading

honekr commented Jan 24, 2025

PSMGoossens commented Jan 25, 2025

steps56 commented Jan 27, 2025 •

edited

Loading

steps56 commented Jan 28, 2025 •

edited

Loading

wills106 commented Jan 30, 2025 •

edited

Loading

smartminjos commented Jan 30, 2025

wills106 commented Jan 30, 2025 •

edited

Loading

PSMGoossens commented Feb 4, 2025 •

edited

Loading

wills106 commented Feb 4, 2025

hubertozog commented Feb 19, 2025

steps56 commented Feb 19, 2025 •

edited

Loading

wills106 commented Feb 20, 2025

steps56 commented Feb 20, 2025

hubertozog commented Feb 20, 2025

wills106 commented Feb 23, 2025

hubertozog commented Feb 23, 2025

wills106 commented Feb 23, 2025 •

edited

Loading

hubertozog commented Feb 24, 2025

PSMGoossens commented Mar 9, 2025

steps56 commented Mar 9, 2025

wills106 commented Mar 12, 2025

[Bug]: BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 #1223

[Bug]: BinaryPayloadDecoder is deprecated and will be removed in v3.9.0 #1223

Comments

wills106 commented Jan 16, 2025

Describe the bug

Integration Version

Homeassistant core version

Inverter brand

Plugin used

Serial prefix

Inverter firmware versions

Connection Method

Dongle firmware

Detailed Error Log

Additional context

PSMGoossens commented Jan 16, 2025

wills106 commented Jan 16, 2025

PSMGoossens commented Jan 16, 2025

smartminjos commented Jan 17, 2025

MrRickwi commented Jan 18, 2025

PSMGoossens commented Jan 18, 2025

flopp999 commented Jan 22, 2025 • edited Loading

honekr commented Jan 24, 2025

PSMGoossens commented Jan 25, 2025

steps56 commented Jan 27, 2025 • edited Loading

steps56 commented Jan 28, 2025 • edited Loading

wills106 commented Jan 30, 2025 • edited Loading

smartminjos commented Jan 30, 2025

wills106 commented Jan 30, 2025 • edited Loading

PSMGoossens commented Feb 4, 2025 • edited Loading

wills106 commented Feb 4, 2025

hubertozog commented Feb 19, 2025

steps56 commented Feb 19, 2025 • edited Loading

wills106 commented Feb 20, 2025

steps56 commented Feb 20, 2025

hubertozog commented Feb 20, 2025

wills106 commented Feb 23, 2025

hubertozog commented Feb 23, 2025

wills106 commented Feb 23, 2025 • edited Loading

hubertozog commented Feb 24, 2025

PSMGoossens commented Mar 9, 2025

steps56 commented Mar 9, 2025

wills106 commented Mar 12, 2025

flopp999 commented Jan 22, 2025 •

edited

Loading

steps56 commented Jan 27, 2025 •

edited

Loading

steps56 commented Jan 28, 2025 •

edited

Loading

wills106 commented Jan 30, 2025 •

edited

Loading

wills106 commented Jan 30, 2025 •

edited

Loading

PSMGoossens commented Feb 4, 2025 •

edited

Loading

steps56 commented Feb 19, 2025 •

edited

Loading

wills106 commented Feb 23, 2025 •

edited

Loading