Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack bundler & Node.JS engine mismatch #38

Closed
cmdshepard opened this issue May 23, 2024 · 1 comment · Fixed by #40
Closed

Webpack bundler & Node.JS engine mismatch #38

cmdshepard opened this issue May 23, 2024 · 1 comment · Fixed by #40
Assignees
Labels
good first issue Good for newcomers

Comments

@cmdshepard
Copy link
Member

Issue
Currently, this library's engines.node in package.json is set to >=0.10.0 (same as React).

However, the Webpack bundler's preset targets node 6.10. This means that Webpack's generated output could potentially be incompatible with older node versions.

Solutions
Option 1: Change Webpack to support older Node versions.
Option 2: Deprecate support for older Node versions.

Whichever solution we choose, it's crucial that we conduct thorough testing to ensure everything is still functioning as expected.

@cmdshepard cmdshepard added the good first issue Good for newcomers label May 23, 2024
@cmdshepard cmdshepard assigned cmdshepard and benyebai and unassigned cmdshepard May 23, 2024
@cmdshepard cmdshepard linked a pull request Jun 7, 2024 that will close this issue
@cmdshepard
Copy link
Member Author

Release v3.0.0 addresses this issue - marking it as closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants