Add missing events (#173)

* Add HubGovernorUpdated emit
* Add ProposalExtended event

Author: alexkeating

evm/src/HubProposalExtender.sol

@@ -30,6 +30,9 @@ contract HubProposalExtender is Ownable, IVoteExtender {
   /// @notice Emitted when the extension duration is updated.
   event ExtensionDurationUpdated(uint48 oldExtension, uint48 newExtension);
 
+  /// @notice Emitted when the proposal deadline has been extended.
+  event ProposalExtended(uint256 proposalId, uint48 newDeadline);
+
   /// @notice Emitted when the vote extender admin is updated.
   event VoteExtenderAdminUpdated(address oldAdmin, address newAdmin);
 
@@ -81,7 +84,9 @@ contract HubProposalExtender is Ownable, IVoteExtender {
     IGovernor.ProposalState state = governor.state(_proposalId);
     if (state != IGovernor.ProposalState.Active) revert ProposalCannotBeExtended();
 
-    extendedDeadlines[_proposalId] = uint48(governor.proposalDeadline(_proposalId)) + extensionDuration;
+    uint48 extendedDeadline = uint48(governor.proposalDeadline(_proposalId)) + extensionDuration;
+    emit ProposalExtended(_proposalId, extendedDeadline);
+    extendedDeadlines[_proposalId] = extendedDeadline;
   }
 
   /// @notice Sets the proposal extension duration.

evm/src/HubVotePool.sol

@@ -35,8 +35,11 @@ contract HubVotePool is QueryResponse, Ownable {
   /// @notice Thrown if a vote query is submitted with an unsupported query type.
   error UnsupportedQueryType();
 
+  /// @notice Emitted when the Governor is updated.
+  event HubGovernorUpdated(address oldGovernor, address newGovernor);
+
   /// @notice Emitted when a new query type is registered.
-  event QueryTypeRegistered(uint16 indexed targetChain, address oldQueryTypeImpl, address newQueryTypeImpl);
+  event QueryTypeRegistered(uint8 indexed queryType, address oldQueryTypeImpl, address newQueryTypeImpl);
 
   /// @notice Emitted when a vote is recorded from a registered spoke vote aggregator.
   event SpokeVoteCast(
@@ -68,9 +71,9 @@ contract HubVotePool is QueryResponse, Ownable {
   mapping(uint8 queryType => ISpokeVoteDecoder voteImpl) public voteTypeDecoder;
 
   constructor(address _core, address _hubGovernor, address _owner) QueryResponse(_core) Ownable(_owner) {
-    hubGovernor = IGovernor(_hubGovernor);
     HubEvmSpokeVoteDecoder evmDecoder = new HubEvmSpokeVoteDecoder(_core, address(this));
     _registerQueryType(address(evmDecoder), QueryResponse.QT_ETH_CALL_WITH_FINALITY);
+    _setGovernor(_hubGovernor);
   }
 
   function getSpoke(uint16 _emitterChainId, uint256 _timepoint) external view returns (bytes32) {
@@ -110,7 +113,7 @@ contract HubVotePool is QueryResponse, Ownable {
   /// @param _newGovernor The address of the new hub governor.
   function setGovernor(address _newGovernor) external {
     _checkOwner();
-    hubGovernor = IGovernor(_newGovernor);
+    _setGovernor(_newGovernor);
   }
 
   /// @notice Processes cross chain votes from the spokes. Parses and verifies the Wormhole query response, then casts
@@ -168,13 +171,19 @@ contract HubVotePool is QueryResponse, Ownable {
   }
 
   function _registerQueryType(address _implementation, uint8 _queryType) internal {
+    emit QueryTypeRegistered(_queryType, address(voteTypeDecoder[_queryType]), _implementation);
+
     if (_implementation == address(0)) {
       delete voteTypeDecoder[_queryType];
       return;
     }
     bool _isValid = _implementation.supportsInterface(type(ISpokeVoteDecoder).interfaceId);
     if (!_isValid) revert InvalidQueryVoteImpl();
-    emit QueryTypeRegistered(_queryType, address(voteTypeDecoder[_queryType]), _implementation);
     voteTypeDecoder[_queryType] = ISpokeVoteDecoder(_implementation);
   }
+
+  function _setGovernor(address _newGovernor) internal {
+    emit HubGovernorUpdated(address(hubGovernor), _newGovernor);
+    hubGovernor = IGovernor(_newGovernor);
+  }
 }

evm/test/HubProposalExtender.t.sol

@@ -120,6 +120,24 @@ contract ExtendProposal is HubProposalExtenderTest {
     assertEq(hubExtender.extendedDeadlines(_proposalId), voteEnd + hubExtender.extensionDuration());
   }
 
+  function testFuzz_EmitsProposalExtendedEvent(address _proposer) public {
+    (, address[] memory delegates) = _setGovernorAndDelegates();
+    vm.startPrank(delegates[0]);
+    ProposalBuilder builder = _createProposal(abi.encodeWithSignature("setHubVotePool(address)", _proposer));
+
+    uint256 _proposalId = governor.propose(builder.targets(), builder.values(), builder.calldatas(), "Hi");
+    vm.stopPrank();
+
+    uint256 voteEnd = governor.proposalDeadline(_proposalId);
+    vm.warp(voteEnd - 1);
+    vm.expectEmit();
+    emit HubProposalExtender.ProposalExtended(_proposalId, uint48(voteEnd) + hubExtender.extensionDuration());
+    vm.prank(whitelistedExtender);
+    hubExtender.extendProposal(_proposalId);
+
+    assertEq(hubExtender.extendedDeadlines(_proposalId), voteEnd + hubExtender.extensionDuration());
+  }
+
   function testFuzz_RevertIf_CallerIsNotTheVoteExtenderAddress(address _caller, uint256 _proposalId) public {
     vm.assume(_caller != whitelistedExtender);
     vm.prank(_caller);

evm/test/HubVotePool.t.sol

@@ -145,6 +145,15 @@ contract Constructor is Test, AddressUtils {
     assertNotEq(address(hubVotePool.voteTypeDecoder(hubVotePool.QT_ETH_CALL_WITH_FINALITY())), address(0));
   }
 
+  function testFuzz_EmitsHubGovernorUpdatedEvent(address _core, address _hubGovernor, address _timelock) public {
+    vm.assume(_core != address(0));
+    vm.assume(_timelock != address(0));
+
+    vm.expectEmit();
+    emit HubVotePool.HubGovernorUpdated(address(0), _hubGovernor);
+    new HubVotePool(_core, _hubGovernor, _timelock);
+  }
+
   function testFuzz_RevertIf_CoreIsZeroAddress(address _hubGovernor, address _timelock) public {
     vm.expectRevert(EmptyWormholeAddress.selector);
     new HubVotePool(address(0), _hubGovernor, _timelock);
@@ -182,6 +191,18 @@ contract RegisterQueryType is HubVotePoolTest {
     assertEq(address(hubVotePool.voteTypeDecoder(_queryType)), address(0));
   }
 
+  function testFuzz_EmitesQueryRegisteredEventWhenSetToZeroAddress(uint8 _queryType) public {
+    vm.startPrank(timelock);
+    hubVotePool.registerQueryType(_queryType, address(hubCrossChainEvmVote));
+
+    vm.expectEmit();
+    emit HubVotePool.QueryTypeRegistered(_queryType, address(hubCrossChainEvmVote), address(0));
+    hubVotePool.registerQueryType(_queryType, address(0));
+    vm.stopPrank();
+
+    assertEq(address(hubVotePool.voteTypeDecoder(_queryType)), address(0));
+  }
+
   function testFuzz_RevertIf_ERC165IsNotSupported(uint8 queryType) public {
     vm.startPrank(timelock);
     GovernorMock gov = new GovernorMock();
@@ -314,6 +335,13 @@ contract SetGovernor is HubVotePoolTest {
     assertEq(address(hubVotePool.hubGovernor()), _newGovernor);
   }
 
+  function testFuzz_EmitsHubGovernorUpdatedEvent(address _newGovernor) public {
+    vm.expectEmit();
+    emit HubVotePool.HubGovernorUpdated(address(hubVotePool.hubGovernor()), _newGovernor);
+    vm.prank(timelock);
+    hubVotePool.setGovernor(_newGovernor);
+  }
+
   function testFuzz_RevertIf_NotCalledByOwner(address _newGovernor, address _caller) public {
     vm.assume(_caller != timelock);
     vm.prank(_caller);