ci: Fix call didn't revert at a lower depth than cheatcode call depth forge error in EVM tests (#591)

nvsriram · web-flow · commit 2d402b98df47 · 2025-02-21T20:13:17.000-05:00
This PR fixes this by adding `/// forge-config: default.allow_internal_expect_revert = true` above the test function.
diff --git a/evm/test/TrimmedAmount.t.sol b/evm/test/TrimmedAmount.t.sol
@@ -67,6 +67,7 @@ contract TrimmingTest is Test {
         }
     }
 
+    /// forge-config: default.allow_internal_expect_revert = true
     function testAddOperatorDecimalsNotEqualRevert() public {
         uint8 decimals = 18;
         uint8 decimalsOther = 3;
@@ -134,6 +135,7 @@ contract TrimmingTest is Test {
         }
     }
 
+    /// forge-config: default.allow_internal_expect_revert = true
     function testSubOperatorOverflow() public {
         uint8[2] memory decimals = [18, 3];
 
@@ -263,6 +265,7 @@ contract TrimmingTest is Test {
         assertEq(expectedTrimmedSub.getDecimals(), trimmedSub.getDecimals());
     }
 
+    /// forge-config: default.allow_internal_expect_revert = true
     function testFuzz_SubOperatorWillOverflow(
         uint8 decimals,
         uint256 amtLeft,

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ contract TrimmingTest is Test {`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
	`70`	`+ /// forge-config: default.allow_internal_expect_revert = true`
`70`	`71`	`function testAddOperatorDecimalsNotEqualRevert() public {`
`71`	`72`	`uint8 decimals = 18;`
`72`	`73`	`uint8 decimalsOther = 3;`
`@@ -134,6 +135,7 @@ contract TrimmingTest is Test {`
`134`	`135`	`}`
`135`	`136`	`}`
`136`	`137`
	`138`	`+ /// forge-config: default.allow_internal_expect_revert = true`
`137`	`139`	`function testSubOperatorOverflow() public {`
`138`	`140`	`uint8[2] memory decimals = [18, 3];`
`139`	`141`
`@@ -263,6 +265,7 @@ contract TrimmingTest is Test {`
`263`	`265`	`assertEq(expectedTrimmedSub.getDecimals(), trimmedSub.getDecimals());`
`264`	`266`	`}`
`265`	`267`
	`268`	`+ /// forge-config: default.allow_internal_expect_revert = true`
`266`	`269`	`function testFuzz_SubOperatorWillOverflow(`
`267`	`270`	`uint8 decimals,`
`268`	`271`	`uint256 amtLeft,`