solana: deny truncation in Cargo.toml instead of GitHub yml

Author: johnsaigle

.github/workflows/solana.yml

@@ -70,7 +70,7 @@ jobs:
         run: cargo check --workspace --tests --manifest-path solana/Cargo.toml
 
       - name: Run `cargo clippy`
-        run: cargo clippy --workspace --tests --manifest-path solana/Cargo.toml -- -Dclippy::cast_possible_truncation
+        run: cargo clippy --workspace --tests --manifest-path solana/Cargo.toml
 
       - name: Cache solana tools
         id: cache-solana

solana/Cargo.toml

@@ -9,7 +9,7 @@ resolver = "2"
 [workspace.lints.clippy]
 # The following rules should be enabled but conflict with other open PRs.
 # TODO enable the commented rules below
-# cast_possible_truncation = "deny"
+cast_possible_truncation = "deny"
 # cast_lossless= "deny"
 # as_conversions = "deny"
 # arithmetic_side_effects = "deny"

solana/programs/example-native-token-transfers/src/bitmap.rs

@@ -31,11 +31,8 @@ impl Bitmap {
         BM::<128>::from_value(self.map).get(index as usize)
     }
 
-    #[allow(clippy::cast_possible_truncation)]
     pub fn count_enabled_votes(&self, enabled: Bitmap) -> u8 {
         let bm = BM::<128>::from_value(self.map) & BM::<128>::from_value(enabled.map);
-        // Conversion from usize to u8 is safe here. The Bitmap uses u128, so it's maximum length
-        // (number of true bits) is 128.
         bm.len() as u8
     }
 }
@@ -67,10 +64,4 @@ mod tests {
         enabled.set(18, false);
         assert_eq!(bm.count_enabled_votes(enabled), 1);
     }
-
-    #[test]
-    fn test_bitmap_len() {
-        let max_bitmap = Bitmap::from_value(u128::MAX);
-        assert_eq!(128, max_bitmap.count_enabled_votes(max_bitmap));
-    }
 }