cli: handle pausers (evm)

Author: kcsongor

cli/src/evmsigner.ts

@@ -147,7 +147,7 @@ export class EvmNativeSigner<N extends Network, C extends EvmChains = EvmChains>
     for (const txn of tx) {
       const { transaction, description } = txn;
       if (this.opts?.debug)
-        console.log(`Signing: ${description} for ${this.address()} (tx: ${transaction.to}})`);
+        console.log(`Signing: ${description} for ${this.address()}`);
 
       const t: TransactionRequest = {
         ...transaction,

cli/src/index.ts

@@ -31,7 +31,6 @@ import type { EvmChains } from "@wormhole-foundation/sdk-evm";
 import { getAvailableVersions, getGitTagName } from "./tag";
 import * as configuration from "./configuration";
 
-// TODO: pauser (evm)
 // TODO: contract upgrades on solana
 // TODO: set special relaying?
 // TODO: currently, we just default all evm chains to standard relaying. should we not do that? what's a good way to configure this?
@@ -66,6 +65,7 @@ export type ChainConfig = {
     mode: Ntt.Mode,
     paused: boolean,
     owner: string,
+    pauser?: string,
     manager: string,
     token: string,
     transceivers: {
@@ -1217,14 +1217,19 @@ async function pushDeployment<C extends Chain>(deployment: Deployment<C>, signer
     const signer = await getSigner(ctx, signerType);
 
     let txs = [];
+    // we perform this last to make sure we don't accidentally lock ourselves out
+    let updateOwner: ReturnType<typeof deployment.ntt.setOwner> | undefined = undefined;
     let managerUpgrade: { from: string, to: string } | undefined;
     for (const k of Object.keys(diff)) {
         if (k === "version") {
             // TODO: check against existing version, and make sure no major version changes
             managerUpgrade = { from: diff[k]!.pull!, to: diff[k]!.push! };
         } else if (k === "owner") {
             const address: AccountAddress<C> = toUniversal(deployment.manager.chain, diff[k]?.push!);
-            txs.push(deployment.ntt.setOwner(address, signer.address.address));
+            updateOwner = deployment.ntt.setOwner(address, signer.address.address);
+        } else if (k === "pauser") {
+            const address: AccountAddress<C> = toUniversal(deployment.manager.chain, diff[k]?.push!);
+            txs.push(deployment.ntt.setPauser(address, signer.address.address));
         } else if (k === "paused") {
             if (diff[k]?.push === true) {
                 txs.push(deployment.ntt.pause(signer.address.address));
@@ -1262,6 +1267,9 @@ async function pushDeployment<C extends Chain>(deployment: Deployment<C>, signer
     for (const tx of txs) {
         await signSendWait(ctx, tx, signer.signer)
     }
+    if (updateOwner) {
+        await signSendWait(ctx, updateOwner, signer.signer)
+    }
 }
 
 async function pullDeployments(deployments: Config, network: Network, verbose: boolean): Promise<Partial<{ [C in Chain]: Deployment<Chain> }>> {
@@ -1336,6 +1344,7 @@ async function pullChainConfig<N extends Network, C extends Chain>(
 
     const paused = await ntt.isPaused();
     const owner = await ntt.getOwner();
+    const pauser = await ntt.getPauser();
 
     const version = getVersion(manager.chain, ntt);
 
@@ -1355,6 +1364,9 @@ async function pullChainConfig<N extends Network, C extends Chain>(
             inbound: {},
         },
     };
+    if (pauser) {
+        config.pauser = pauser.toString();
+    }
     return [config, ch, ntt, decimals];
 }
 

sdk/definitions/src/ntt.ts

@@ -146,8 +146,12 @@ export interface Ntt<N extends Network, C extends Chain> {
 
   getOwner(): Promise<AccountAddress<C>>;
 
+  getPauser(): Promise<AccountAddress<C> | null>;
+
   setOwner(newOwner: AccountAddress<C>, payer?: AccountAddress<C>): AsyncGenerator<UnsignedTransaction<N, C>>;
 
+  setPauser(newOwner: AccountAddress<C>, payer?: AccountAddress<C>): AsyncGenerator<UnsignedTransaction<N, C>>;
+
   getThreshold(): Promise<number>;
 
   setPeer(

sdk/evm/src/ntt.ts

@@ -201,6 +201,10 @@ export class EvmNtt<N extends Network, C extends EvmChains>
     return new EvmAddress(await this.manager.owner()) as AccountAddress<C>;
   }
 
+  async getPauser(): Promise<AccountAddress<C> | null> {
+    return new EvmAddress(await this.manager.pauser()) as AccountAddress<C>;
+  }
+
   async *setOwner(owner: AccountAddress<C>) {
     const canonicalOwner = canonicalAddress({chain: this.chain, address: owner});
     const tx = await this.manager.transferOwnership.populateTransaction(canonicalOwner);

solana/ts/sdk/ntt.ts

@@ -189,6 +189,10 @@ export class SolanaNtt<N extends Network, C extends SolanaChains>
     return new SolanaAddress(config.owner) as AccountAddress<C>;
   }
 
+  async getPauser(): Promise<AccountAddress<C> | null> {
+    return null
+  }
+
   async *setOwner(newOwner: AccountAddress<C>, payer: AccountAddress<C>) {
     const sender = new SolanaAddress(payer).unwrap();
     const ix = await NTT.createTransferOwnershipInstruction(this.program, {
@@ -201,6 +205,10 @@ export class SolanaNtt<N extends Network, C extends SolanaChains>
     yield this.createUnsignedTx({ transaction: tx }, "Ntt.SetOwner");
   }
 
+  async *setPauser(_newPauser: AccountAddress<C>, _payer: AccountAddress<C>) {
+    throw new Error("Pauser role not supported on Solna.");
+  }
+
   async isRelayingAvailable(destination: Chain): Promise<boolean> {
     if (!this.quoter) return false;
     return await this.quoter.isRelayEnabled(destination);