Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate NTT route for Wormhole Connect #1585

Closed
Tracked by #1747
aadam-10 opened this issue Jan 31, 2024 · 1 comment · Fixed by #1674 or #1889
Closed
Tracked by #1747

Integrate NTT route for Wormhole Connect #1585

aadam-10 opened this issue Jan 31, 2024 · 1 comment · Fixed by #1674 or #1889
Assignees

Comments

@aadam-10
Copy link
Contributor

No description provided.

@kev1n-peters
Copy link
Contributor

kev1n-peters commented Feb 13, 2024

Objective

Enable users to transfer "NTT" tokens between supported chains. Users should have the option to manually execute the transfer (requiring 2 transactions) or use relayers for automatic transfer (requiring 1 transaction). Initially this will only support NTT tokens that use Wormhole verification (WormholeTransceiver contract).

Specifications

  • [x ] Manual NTT transfer: User incurs gas costs on both the source and destination chains, requiring 2 transactions.
  • [x ] Automatic NTT transfer: User incurs gas costs and relayer fee on the source chain only, requiring 1 transaction. The relayer completes the transfer on the destination chain. Standard relayers are used for transfers between EVM chains, while specialized relayers are used for transfers to and from Solana.

Error Cases

  • Source chain rate-limits (outbound): If the user would be rate-limited on the source chain, display a warning message and prevent the initiation of the transfer.
  • Destination chain rate-imits (inbound): If the user is rate-limited on the destination chain, display a warning message and mention clearly that the user will need to resume the transfer in a new transaction after the rate limit expires. Also display when the rate limit expires. Display a warning if the user would likely be inbound rate-limited before the transfer on the source chain is even initiated.
  • [x ] Source chain contract paused: If the contract is paused on the source chain, prevent the user from initiating a transfer.
  • Destination chain contract paused: If the contract is paused on the destination chain, prevent the user from initiating a transfer.
  • Standard relayer delivery failure: Display an error message with the revert reason. NOTE: Re-delivery support is out of scope.
  • Specialized relayer delivery failure: Delivery should be guaranteed unless the contract reverts (gas limit too low or misconfigured).

Sorry, something went wrong.

kev1n-peters added a commit that referenced this issue Feb 14, 2024
kev1n-peters added a commit that referenced this issue Feb 14, 2024
kev1n-peters added a commit that referenced this issue Feb 14, 2024
kev1n-peters added a commit that referenced this issue Feb 15, 2024
kev1n-peters added a commit that referenced this issue Feb 15, 2024
kev1n-peters added a commit that referenced this issue Feb 16, 2024
Addresses #1585
kev1n-peters added a commit that referenced this issue Feb 16, 2024
@aadam-10 aadam-10 linked a pull request Feb 16, 2024 that will close this issue
kev1n-peters added a commit that referenced this issue Feb 28, 2024
kev1n-peters added a commit that referenced this issue Mar 12, 2024
kev1n-peters added a commit that referenced this issue Mar 19, 2024
kev1n-peters added a commit that referenced this issue Mar 21, 2024
kev1n-peters added a commit that referenced this issue Mar 28, 2024
kev1n-peters added a commit that referenced this issue Apr 1, 2024
kev1n-peters added a commit that referenced this issue Apr 3, 2024
kev1n-peters added a commit that referenced this issue Apr 4, 2024
kev1n-peters added a commit that referenced this issue Apr 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Feature: Native Token Transfers (NTT) integration

Addresses #1585

* Use SDKv2 layouts for message parsing

* renamed platforms -> chains

* added sepolia cctp, removed goerli cctp

* reworked ntt config, added ntt groups

* usdc switch chains fix

* custom ntt group support

* abi version support, added 0.1.0 abis

* Updated testnet addresses

* updated testnet USDC.e address

* rebased development

* updated 0.1.0 ABI, avax-celo addresses

* delivery price wormhole fee for manual xfers fix

* removed comment

* removed old testnet ntt token configs

* Added NTT to README

* Added Fantom bridged USDC NTT addresses
@aadam-10 aadam-10 linked a pull request Apr 5, 2024 that will close this issue
yuli-ferna pushed a commit that referenced this issue Apr 9, 2024
* Feature: Native Token Transfers (NTT) integration

Addresses #1585

* Use SDKv2 layouts for message parsing

* renamed platforms -> chains

* added sepolia cctp, removed goerli cctp

* reworked ntt config, added ntt groups

* usdc switch chains fix

* custom ntt group support

* abi version support, added 0.1.0 abis

* Updated testnet addresses

* updated testnet USDC.e address

* rebased development

* updated 0.1.0 ABI, avax-celo addresses

* delivery price wormhole fee for manual xfers fix

* removed comment

* removed old testnet ntt token configs

* Added NTT to README

* Added Fantom bridged USDC NTT addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants