Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integrator way to configure Solana priority fees #1697

Closed
Tracked by #1716
tonyjin opened this issue Feb 22, 2024 · 2 comments · Fixed by #1755
Closed
Tracked by #1716

Add integrator way to configure Solana priority fees #1697

tonyjin opened this issue Feb 22, 2024 · 2 comments · Fixed by #1755
Assignees
Labels
enhancement New feature or request tested-NOK

Comments

@tonyjin
Copy link
Contributor

tonyjin commented Feb 22, 2024

Description and context

Solana transactions require setting a priority fee to land transactions during periods of high congestion.

See:

I propose adding a config that allows users to pass in a method for calculating appropriate Solana priority fees to set per transaction. Passing in a method allows integrators to customize how they calculate this, including:

  • using Solana RPC getRecentPriorityFees to estimate based on past priority fees
  • using Helius getPriorityFeeEstimate to lean on an external service to estimate appropriate priority fees
@artursapek
Copy link
Collaborator

artursapek commented Mar 1, 2024

I've looked into this and know generally how to get it done. however, it depends on #1698 merging first, which enables to add non-JSON-serializable things functions into the integration config. as of right now, because Connect only supports a stringified JSON config, we literally can't do this.

@aadam-10 aadam-10 linked a pull request Mar 7, 2024 that will close this issue
artursapek added a commit that referenced this issue Mar 8, 2024
* set priority fee for solana transactions

* always set compute unit limit & price

* set fee to 75th percentile of recent fees paid

* include mintAddress

* fix try/catch
@tsadovska
Copy link
Collaborator

  1. "TransactionExpiredTimeoutError" appears in Console when sending assets from Solana. Checked on https://wormhole-connect-mainnet.netlify.app/ [Mainnet] and https://preview.portalbridge.com/b1ba6e856a/ [Mainnet]. Ticket [QA] [Mainnet] Transactions from Solana fails with "TransactionExpiredTimeoutError" error #1689.

  2. "TransactionExpiredBlockheightExceededError" appears in Console when sending assets to Solana. Checked on https://wormhole-connect-mainnet.netlify.app/ [Mainnet] and https://preview.portalbridge.com/b1ba6e856a/ [Mainnet]. Ticket [QA] "TransactionExpiredBlockheightExceededError" when claiming on Solana #1754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tested-NOK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants