cloud_functions: await everything

panoel · panoel · commit 76f7f42b805c · 2024-02-07T12:50:25.000-06:00
diff --git a/cloud_functions/src/getReobserveVaas.ts b/cloud_functions/src/getReobserveVaas.ts
@@ -30,7 +30,8 @@ export async function getReobserveVaas(req: any, res: any) {
     res.sendStatus(500);
   }
   let reobs: ReobserveInfo[] = [];
-  reobsMap.forEach(async (vaa) => {
+  const vaaArray = Array.from(reobsMap.values());
+  const promises = vaaArray.map(async (vaa) => {
     let push: boolean = true;
     if (vaa.chain === CHAIN_ID_SOLANA) {
       const origTxHash = vaa.txhash;
@@ -45,6 +46,7 @@ export async function getReobserveVaas(req: any, res: any) {
       reobs.push(vaa);
     }
   });
+  await Promise.all(promises);
   res.status(200).send(JSON.stringify(reobs));
   return;
 }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,8 @@ export async function getReobserveVaas(req: any, res: any) {`
`30`	`30`	`res.sendStatus(500);`
`31`	`31`	`}`
`32`	`32`	`let reobs: ReobserveInfo[] = [];`
`33`		`- reobsMap.forEach(async (vaa) => {`
	`33`	`+ const vaaArray = Array.from(reobsMap.values());`
	`34`	`+ const promises = vaaArray.map(async (vaa) => {`
`34`	`35`	`let push: boolean = true;`
`35`	`36`	`if (vaa.chain === CHAIN_ID_SOLANA) {`
`36`	`37`	`const origTxHash = vaa.txhash;`
`@@ -45,6 +46,7 @@ export async function getReobserveVaas(req: any, res: any) {`
`45`	`46`	`reobs.push(vaa);`
`46`	`47`	`}`
`47`	`48`	`});`
	`49`	`+ await Promise.all(promises);`
`48`	`50`	`res.status(200).send(JSON.stringify(reobs));`
`49`	`51`	`return;`
`50`	`52`	`}`