historical_uptime: clean up code

Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>

Author: bingyuyap

fly/pkg/db/index.go

@@ -12,9 +12,6 @@ import (
 const (
 	// Format for metricsChecked index key: metricsChecked|<bool>|<messageID>
 	metricsCheckedIndexKeyFmt = "metricsChecked|%t|%s"
-	// Format for lastObservedAt index key: lastObservedAt|<timestamp>|<messageID>
-	// timestamp is in the format "20060102150405" (YYYYMMDDHHMMSS)
-	lastObservedAtIndexKeyFmt = "lastObservedAt|%s|%s"
 )
 
 // CreateOrUpdateIndex creates or updates indexes for a message
@@ -25,16 +22,10 @@ func CreateOrUpdateIndex(txn *badger.Txn, message *Message) error {
 		return fmt.Errorf("failed to set metricsChecked index: %w", err)
 	}
 
-	// Index for lastObservedAt
-	loaKey := fmt.Sprintf(lastObservedAtIndexKeyFmt, message.LastObservedAt.Format("20060102150405"), message.MessageID)
-	if err := txn.Set([]byte(loaKey), []byte(message.MessageID)); err != nil {
-		return fmt.Errorf("failed to set lastObservedAt index: %w", err)
-	}
-
 	return nil
 }
 
-// Helper function to parse index key and extract values
+// parseMetricsCheckedIndexKey helper function to parse index key and extract values
 func parseMetricsCheckedIndexKey(key []byte) (bool, string, error) {
 	keyStr := string(key) // Convert byte slice to string
 	parts := strings.Split(keyStr, "|")

fly/pkg/db/message.go

@@ -14,9 +14,9 @@ import (
 
 // Message represents the data structure for a message in the Observations table.
 type Message struct {
-	MessageID      MessageID        `json:"messageId"`
+	MessageID      MessageID     `json:"messageId"`
 	LastObservedAt time.Time     `json:"lastObservedAt"`
-	Observations   []Observation `json:"guardians"`
+	Observations   []Observation `json:"observations"`
 	MetricsChecked bool          `json:"metricsChecked"`
 }
 
@@ -44,6 +44,7 @@ type ObservationStatus int
 
 const (
 	OnTime ObservationStatus = iota
+	// Late indicates that the observation was made 30 hours after the last observed timestamp
 	Late
 )