Skip to content

Commit 4063d0b

Browse files
committed
format
1 parent 6e1b033 commit 4063d0b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

DESIGN.md

-2
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,3 @@ Several interfaces should be available for each platform supported.
4444
A Protocol (fka `Module`) is a specific application, it provides a set of methods that can be called to accomplish some action (e.g. `TokenBridge` allows `transfer`/`redeem`/`getWrappedAsset`, etc...)
4545

4646
To allow platform agnostic access to Protocols, each Platform that provides the protocol should have its own implementation.
47-
48-

notes.md

+10-8
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,18 @@ The [token registry](./tokenRegistry/) directory is unused except for importing
1010

1111
It is still possible to screw up a transfer (blackhole funds) if the higher level constructs are not used and care is not taken to produce a transfer that is acceptable by the destination chain. I have no suggestions for this that would prevent the platform-specific-oddities from leaking into packages they have no business in besides "better documentation".
1212

13-
Invalid ATA receiver:
14-
https://wormholescan.io/#/tx/0x1605bd06e15d46398c061bd2fc24e65c2b580d07c3e7a4ca9a0643bf91d16a7c
15-
https://wormholescan.io/#/tx/DnEXtm2NdLhT5RszHc7nR7LPNATzGSP3kmbC2GQkAJyK
13+
Examples:
1614

17-
An [issue](https://github.com/wormhole-foundation/wormhole/issues/3992) has been filed to reduce the danger for this one.
15+
- Invalid ATA receiver for Solana destined transfer. An [issue](https://github.com/wormhole-foundation/wormhole/issues/3992) has been filed to reduce the danger for this one.
1816

19-
Incorrect contract address in payload:
20-
https://wormholescan.io/#/tx/2g4nn6fWZCkphxeMGfqjzViZYo3XAYarYTSvTcxYY95JAtZvwVd7MKY6RWHhhHd8oBzeFWjuTkXNo4tdVVTwBWfo
17+
- https://wormholescan.io/#/tx/0x1605bd06e15d46398c061bd2fc24e65c2b580d07c3e7a4ca9a0643bf91d16a7c
18+
- https://wormholescan.io/#/tx/DnEXtm2NdLhT5RszHc7nR7LPNATzGSP3kmbC2GQkAJyK
19+
20+
21+
- Incorrect contract address in payload, caused by a bug that allowed an empty address to be passed for the remote contract.
22+
23+
- https://wormholescan.io/#/tx/2g4nn6fWZCkphxeMGfqjzViZYo3XAYarYTSvTcxYY95JAtZvwVd7MKY6RWHhhHd8oBzeFWjuTkXNo4tdVVTwBWfo
2124

22-
Caused by a bug that allowed an empty address to be passed for the remote contract.
2325

2426
## Core
2527

@@ -61,7 +63,7 @@ The classes that implement the [WormholeTransfer](./connect/src/protocols/wormho
6163

6264
Every Protocol implementation defines its own private `createUnsignedTransaction` function, which, kinda sucks.
6365

64-
The Signer implementations are bad at things like gas estimation or handling errors.
66+
The Signer implementations are bad at things like gas estimation or handling errors. It should also provide better support for transaction review prior to signing and sending.
6567

6668

6769
### Evm

0 commit comments

Comments
 (0)