You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: DESIGN.md
-2
Original file line number
Diff line number
Diff line change
@@ -44,5 +44,3 @@ Several interfaces should be available for each platform supported.
44
44
A Protocol (fka `Module`) is a specific application, it provides a set of methods that can be called to accomplish some action (e.g. `TokenBridge` allows `transfer`/`redeem`/`getWrappedAsset`, etc...)
45
45
46
46
To allow platform agnostic access to Protocols, each Platform that provides the protocol should have its own implementation.
Copy file name to clipboardexpand all lines: notes.md
+10-8
Original file line number
Diff line number
Diff line change
@@ -10,16 +10,18 @@ The [token registry](./tokenRegistry/) directory is unused except for importing
10
10
11
11
It is still possible to screw up a transfer (blackhole funds) if the higher level constructs are not used and care is not taken to produce a transfer that is acceptable by the destination chain. I have no suggestions for this that would prevent the platform-specific-oddities from leaking into packages they have no business in besides "better documentation".
An [issue](https://github.com/wormhole-foundation/wormhole/issues/3992) has been filed to reduce the danger for this one.
15
+
- Invalid ATA receiver for Solana destined transfer. An [issue](https://github.com/wormhole-foundation/wormhole/issues/3992) has been filed to reduce the danger for this one.
Caused by a bug that allowed an empty address to be passed for the remote contract.
23
25
24
26
## Core
25
27
@@ -61,7 +63,7 @@ The classes that implement the [WormholeTransfer](./connect/src/protocols/wormho
61
63
62
64
Every Protocol implementation defines its own private `createUnsignedTransaction` function, which, kinda sucks.
63
65
64
-
The Signer implementations are bad at things like gas estimation or handling errors.
66
+
The Signer implementations are bad at things like gas estimation or handling errors. It should also provide better support for transaction review prior to signing and sending.
0 commit comments