Skip to content

Commit d61cc30

Browse files
authored
amount.display: Don't add trailing zeros by default (#696)
* don't add trailing zeros by default * put padEnd back * fix test
1 parent cc51d7c commit d61cc30

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

core/base/__tests__/amount.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe("Amount Tests", function () {
7979
[{ amount: "1", decimals: 18 }, 20, "0.00000000000000000100"],
8080
[{ amount: "5020", decimals: 2 }, 0, "50.2"],
8181
[{ amount: "5020", decimals: 2 }, 4, "50.2000"],
82-
[{ amount: "5020", decimals: 2 }, undefined, "50.20"],
82+
[{ amount: "5020", decimals: 2 }, undefined, "50.2"],
8383
[{ amount: "1", decimals: 0 }, 0, "1"],
8484
];
8585

core/base/src/utils/amount.ts

+4
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,10 @@ export function display(amount: Amount, precision?: number): string {
157157
partial = partial.substring(0, partial.length - 1);
158158
}
159159
partial = partial.padEnd(precision, "0");
160+
} else {
161+
// If no specific precision is given, just trim trailing zeroes
162+
// and return all significant digits.
163+
partial = partial.replace(/0+$/, '');
160164
}
161165

162166
return partial.length > 0 ? `${whole}.${partial}` : whole;

0 commit comments

Comments
 (0)