From 980522d63622013cbfc04cbff6fe70a668623b78 Mon Sep 17 00:00:00 2001 From: crStiv Date: Sat, 7 Dec 2024 18:49:20 +0100 Subject: [PATCH 1/6] typos --- __tests__/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/__tests__/README.md b/__tests__/README.md index fcacbcd60..e4b17af96 100644 --- a/__tests__/README.md +++ b/__tests__/README.md @@ -16,7 +16,7 @@ The `__test__/mocks` directory should contain mocks for things like RPCs and Sig Each platform should have a `__test__/integration/fixtures` directory that contains fixtures for complex blockchain data structures -Using nock, we can gather the request/responses and using jest.mock, mock the RPC calls to return the fixtures. This allows us to test the code without having to make RPC calls to the blockchain. +Using nock, we can gather the requests/responses and use jest.mock, mock the RPC calls to return the fixtures. This allows us to test the code without having to make RPC calls to the blockchain. ## End-to-End Tests @@ -30,4 +30,4 @@ https://github.com/wormhole-foundation/wormhole-circle-integration/blob/main/evm https://github.com/circlefin/evm-cctp-contracts/blob/master/anvil/crosschainTransferIT.py#L261 ---> \ No newline at end of file +--> From ab30973ba8cbfec7cbbc7406f2c68b65070be8ec Mon Sep 17 00:00:00 2001 From: crStiv Date: Sat, 7 Dec 2024 19:16:42 +0100 Subject: [PATCH 2/6] multiple typos --- connect/src/protocols/gateway/gatewayTransfer.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/connect/src/protocols/gateway/gatewayTransfer.ts b/connect/src/protocols/gateway/gatewayTransfer.ts index 9d2a91010..139bd1c28 100644 --- a/connect/src/protocols/gateway/gatewayTransfer.ts +++ b/connect/src/protocols/gateway/gatewayTransfer.ts @@ -51,18 +51,18 @@ export class GatewayTransfer implements WormholeTra private _state: TransferState; // cached message derived from transfer details - // note: we dont want to create multiple different ones since + // note: we don't want to create multiple different ones since // the nonce may change and we want to keep it consistent private msg: GatewayTransferMsg | GatewayTransferWithPayloadMsg; // Initial Transfer Settings transfer: GatewayTransferDetails; - // Transaction Ids from source chain + // Transaction IDs from the source chain transactions: TransactionId[] = []; // The corresponding vaa representing the GatewayTransfer - // on the source chain (if it came from outside cosmos and if its been completed and finalized) + // on the source chain (if it came from outside cosmos and if it has been completed and finalized) vaas?: { id: WormholeMessageId; vaa?: TokenBridge.TransferVAA; @@ -146,7 +146,7 @@ export class GatewayTransfer implements WormholeTra gtd = await GatewayTransfer._fromTransaction(wh, from); } else if (isWormholeMessageId(from)) { // TODO: we're missing the transaction that created this - // get it from transaction status search on wormholescan? + // get it from a transaction status search on wormholescan? gtd = await GatewayTransfer._fromMsgId(wh, from); } else { throw new Error("Invalid `from` parameter for GatewayTransfer"); @@ -179,13 +179,13 @@ export class GatewayTransfer implements WormholeTra vaa.payloadName === "TransferWithPayload" ? vaa.payload.payload : undefined; // Nonce for GatewayTransferMessage may be in the payload - // and since we use the payload to find the Wormchain transacton + // and since we use the payload to find the Wormchain transaction // we need to preserve it let nonce: number | undefined; let to: ChainAddress = { ...vaa.payload.to }; // The payload here may be the message for Gateway - // Lets be sure to pull the real payload if its set + // Let's be sure to pull the real payload if it's set // Otherwise revert to undefined if (payload) { try { @@ -202,7 +202,7 @@ export class GatewayTransfer implements WormholeTra ); to = Wormhole.chainAddress(destChain, recipientAddress); } catch { - /*Ignoring, throws if not the payload isnt JSON*/ + /*Ignoring, throws if not the payload isn't JSON*/ } } From 678e72b327cf628366a997d7c6abeddfb7b6e0f3 Mon Sep 17 00:00:00 2001 From: crStiv Date: Sat, 7 Dec 2024 19:28:19 +0100 Subject: [PATCH 3/6] redundancy --- core/base/src/constants/tokens/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/base/src/constants/tokens/index.ts b/core/base/src/constants/tokens/index.ts index b07d0dea9..94af1784f 100644 --- a/core/base/src/constants/tokens/index.ts +++ b/core/base/src/constants/tokens/index.ts @@ -81,6 +81,6 @@ export function getCanonicalToken( const original = getTokensBySymbol(network, token.original, token.symbol); if (!original) return; - // return the the token with this symbol where no `original` field exists + // return the token with this symbol where no `original` field exists return original.find((t) => !t.original); } From 0347b4c7eda59a0fcb0dee1a1d352dd58a1a29a6 Mon Sep 17 00:00:00 2001 From: crStiv Date: Sat, 7 Dec 2024 19:38:30 +0100 Subject: [PATCH 4/6] typo --- core/definitions/__tests__/governanceVaa.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/definitions/__tests__/governanceVaa.ts b/core/definitions/__tests__/governanceVaa.ts index 0aa82e977..b48073ce9 100644 --- a/core/definitions/__tests__/governanceVaa.ts +++ b/core/definitions/__tests__/governanceVaa.ts @@ -78,7 +78,7 @@ const guardianSetUpgrade = /*nonce*/ "9e0c5dfa" + /*emitterChain*/ "0001" + /*emitterAddress*/ "0000000000000000000000000000000000000000000000000000000000000004" + - /*seqeuence*/ "6c5a054d7833d1e4" + + /*sequence*/ "6c5a054d7833d1e4" + /*consistencyLevel*/ "20" + /*module*/ "00000000000000000000000000000000000000000000000000000000436f7265" + /*action*/ "02" + From 38c56525746a4f7bd09f00b9e78040a86d836cac Mon Sep 17 00:00:00 2001 From: crStiv Date: Sun, 8 Dec 2024 01:36:05 +0100 Subject: [PATCH 5/6] typo --- core/definitions/src/protocols/governance/layout.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/definitions/src/protocols/governance/layout.ts b/core/definitions/src/protocols/governance/layout.ts index a9a6f9ae8..990cd77ce 100644 --- a/core/definitions/src/protocols/governance/layout.ts +++ b/core/definitions/src/protocols/governance/layout.ts @@ -47,7 +47,7 @@ const contractActions = [ //a word on the chainId for RecoverChainId: //The EVM contracts accept an arbitrary number when recovering chain ids however I don't think you // ever want to set the wormhole chain id of a contract (even on a fork) to 0 since this would - // mean that afterwards all the checks that use `vaa.chainId == this.chainId` in the contract + //means that afterwards all the checks that use `vaa.chainId == this.chainId` in the contract // would suddenly accept "broadcast VAAs" which is almost certainly not what's intended. //TODO should we define governance actions that are platform specific here? // (reason against: we might want to deserialize types that are specific to the platform) @@ -95,7 +95,7 @@ const wormchainActions = [ // It has a variable length string that has no length prefix as its first item followed by a uint. // So deserialization has to reason backwards to determine the length. // see: https://github.com/wormhole-foundation/wormhole/blob/2eb5cca8e72c5379cd444ae3f25a012c1e04ad65/sdk/vaa/payloads.go#L396-L407 -// We have to do a bit of footwork here to accomodate this oddity. +// We have to do a bit of footwork here to accommodate this oddity. const gatewayScheduleUpgradeItem = (() => { const stringBytesLayout = (size: number) => ({ binary: "bytes", size, custom: stringConversion } as const satisfies Layout); From c5dd2186ce67e053bfaacc1543f9b536b0edc726 Mon Sep 17 00:00:00 2001 From: crStiv Date: Sun, 8 Dec 2024 01:42:03 +0100 Subject: [PATCH 6/6] typo --- core/definitions/src/vaa/registration.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/definitions/src/vaa/registration.ts b/core/definitions/src/vaa/registration.ts index e3042abc7..f06b1bfeb 100644 --- a/core/definitions/src/vaa/registration.ts +++ b/core/definitions/src/vaa/registration.ts @@ -7,7 +7,7 @@ import type { ProtocolName } from "../protocol.js"; // // payload types that are declared in different protocols. This allows us to have full type safety // // when constructing payloads via the factory without having to ever declare the mapping of all // // payloads and their respective layouts in a single place (which, besides being a terrible code -// // smell, would also prevent users of the SDK to register their own payload types!) +// // smell, would also prevent users of the SDK from registering their own payload types!) // export namespace WormholeRegistry { // //effective type: Record // export interface PayloadLiteralToLayoutMapping {}