fix: appeals implement sequential appeals fail (#637)

* feat: add rollup transaction db table

* fix: drop audit table, change id and nonce of rollup, only make one finalized rollup transaction

* create rollup transaction for every validator

* add function to mock in consensus test

* feat: add appeal window, accepted queue, basic test

* fix: old tests were stuck on accepted state, add usage of thread

* refactor consensus into states

* feat: added appeal flow when transaction is accepted including the loop when appeal failed and succeeded

* fix: adding tests for appeals and fixing minor bugs

* refactor: merge main and PR #573 into this branch

* feat: add appeal_failed in db, select new validators when appealed based on formula

* docs: cleanup consensus mechanism base file

* test: checking the number of validators for different appeals

* refactor: merge 593-appeals-add-validators-when-appealed into 604-appeals-implement-sequential-appeals-fail

* refactor: merging changed file permissions

* fix: appealing a write method gave a KeyError because of wrong conversation of transaction

* docs: update transaction_processor argument description

* fix: all appeals disagreed because of pending_transactions type

* docs: describe calculation of get_extra_validators

* refactor: make calculation in get_extra_validators clearer

* refactor: make get_extra_validators more clear

Author: kstroobants

.env.example

@@ -60,6 +60,7 @@ BACKEND_BUILD_TARGET    = 'debug'     # change to 'prod' or remove to run in pro
 HARDHAT_URL = 'http://hardhat'
 HARDHAT_PORT = '8545'
 HARDHAT_PRIVATE_KEY = '0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80'
+
 # LLM Providers Configuration
 # If you want to use OpenAI LLMs, add your key here
 OPENAIKEY               = '<add_your_openai_api_key_here>'

backend/consensus/base.py

@@ -0,0 +1,35 @@
+"""appeal_failed
+
+Revision ID: 2a4ac5eb9455
+Revises: b9421e9f12aa
+Create Date: 2024-11-22 09:48:50.048787
+
+"""
+
+from typing import Sequence, Union
+
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision: str = "2a4ac5eb9455"
+down_revision: Union[str, None] = "b9421e9f12aa"
+branch_labels: Union[str, Sequence[str], None] = None
+depends_on: Union[str, Sequence[str], None] = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.add_column(
+        "transactions", sa.Column("appeal_failed", sa.Integer(), nullable=True)
+    )
+    # Set all existing 'appeal_failed' values to 0
+    op.execute("UPDATE transactions SET appeal_failed = 0 WHERE appeal_failed IS NULL")
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_column("transactions", "appeal_failed")
+    # ### end Alembic commands ###

backend/database_handler/migration/versions/2a4ac5eb9455_appeal_failed.py

@@ -95,6 +95,7 @@ class Transactions(Base):
     s: Mapped[Optional[int]] = mapped_column(Integer)
     v: Mapped[Optional[int]] = mapped_column(Integer)
     ghost_contract_address: Mapped[Optional[str]] = mapped_column(String(255))
+    appeal_failed: Mapped[Optional[int]] = mapped_column(Integer)
 
     # Relationship for triggered transactions
     triggered_by_hash: Mapped[Optional[str]] = mapped_column(

backend/database_handler/models.py

@@ -62,6 +62,7 @@ def _parse_transaction_data(transaction_data: Transactions) -> dict:
             "ghost_contract_address": transaction_data.ghost_contract_address,
             "appealed": transaction_data.appealed,
             "timestamp_accepted": transaction_data.timestamp_accepted,
+            "appeal_failed": transaction_data.appeal_failed,
         }
 
     @staticmethod
@@ -225,6 +226,7 @@ def insert_transaction(
             ghost_contract_address=ghost_contract_address,
             appealed=False,
             timestamp_accepted=None,
+            appeal_failed=0,
         )
 
         self.session.add(new_transaction)
@@ -356,3 +358,11 @@ def set_transaction_timestamp_accepted(
             transaction.timestamp_accepted = timestamp_accepted
         else:
             transaction.timestamp_accepted = int(time.time())
+
+    def set_transaction_appeal_failed(self, transaction_hash: str, appeal_failed: int):
+        if appeal_failed < 0:
+            raise ValueError("appeal_failed must be a non-negative integer")
+        transaction = (
+            self.session.query(Transactions).filter_by(hash=transaction_hash).one()
+        )
+        transaction.appeal_failed = appeal_failed

backend/database_handler/transactions_processor.py

@@ -84,6 +84,7 @@ class Transaction:
     ghost_contract_address: str | None = None
     appealed: bool = False
     timestamp_accepted: int | None = None
+    appeal_failed: int = 0
 
     def to_dict(self):
         return {
@@ -106,6 +107,7 @@ def to_dict(self):
             "ghost_contract_address": self.ghost_contract_address,
             "appealed": self.appealed,
             "timestamp_accepted": self.timestamp_accepted,
+            "appeal_failed": self.appeal_failed,
         }
 
     @classmethod
@@ -130,4 +132,5 @@ def from_dict(cls, input: dict) -> "Transaction":
             ghost_contract_address=input.get("ghost_contract_address"),
             appealed=input.get("appealed"),
             timestamp_accepted=input.get("timestamp_accepted"),
+            appeal_failed=input.get("appeal_failed", 0),
         )

backend/domain/types.py

@@ -182,11 +182,11 @@ def from_dict(cls, input: dict) -> Optional["Receipt"]:
                 mode=ExecutionMode.from_string(input.get("mode")),
                 contract_state=input.get("contract_state"),
                 node_config=input.get("node_config"),
-                eq_outputs=input.get("eq_outputs"),
-                pending_transactions=tuple(
+                eq_outputs={int(k): v for k, v in input.get("eq_outputs", {}).items()},
+                pending_transactions=[
                     PendingTransaction.from_dict(pending_transaction)
                     for pending_transaction in input.get("pending_transactions", [])
-                ),
+                ],
             )
         else:
             return None