-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SIM-BE-expose GenVM errors on RPC #1022
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 14.81% 14.81%
=======================================
Files 123 123
Lines 7364 7364
Branches 254 254
=======================================
Hits 1091 1091
Misses 6194 6194
Partials 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Now the receipt looks like this when I write an error in the contract code:
|
|
Fixes #771
What
genvm_result
to theReceipt
class to includestdout
andstderr
from thegenvm
execution.to_dict
andfrom_dict
methods in theReceipt
class to handle the newgenvm_result
field.Why
genvm
execution in the receipt, which can help in debugging and understanding the execution flow.Testing done
genvm_result
is correctly populated in theReceipt
object.Receipt
object to ensuregenvm_result
is handled properly.Decisions made
stdout
andstderr
for flexibility and ease of access.Checks
Reviewing tips
Receipt
class and ensure that thegenvm_result
is correctly integrated.User facing release notes
The receipt now includes detailed
genvm
execution results.