|
1 | 1 | # Contributing
|
2 | 2 |
|
3 | 3 | ## Getting Started
|
4 |
| - * Fork, then clone the repo: |
| 4 | + |
| 5 | +* Fork, then clone the repo: |
| 6 | + |
5 | 7 | ```bash
|
6 | 8 | git clone git@github.com:your-username/php-jsonrpc-http-server-swagger-doc-sdk.git
|
7 |
| -```` |
| 9 | +``` |
| 10 | + |
| 11 | +* Make sure everything goes well: |
8 | 12 |
|
9 |
| - * Make sure everything goes well: |
10 | 13 | ```bash
|
11 | 14 | make build
|
12 | 15 | make test
|
13 | 16 | ```
|
14 | 17 |
|
15 |
| - * Make your changes (Add/Update tests according to your changes). |
16 |
| - * Make sure tests are still green: |
| 18 | +* Make your changes (Add/Update tests according to your changes). |
| 19 | +* Make sure tests are still green: |
| 20 | + |
17 | 21 | ```bash
|
18 | 22 | make test
|
19 | 23 | ```
|
20 | 24 |
|
21 |
| - * To check code coverage, launch |
| 25 | +* To check code coverage, launch |
| 26 | + |
22 | 27 | ```bash
|
23 | 28 | make coverage
|
24 | 29 | ```
|
25 | 30 |
|
26 |
| - * Push to your fork and [submit a pull request](https://github.com/yoanm/php-jsonrpc-http-server-swagger-doc-sdk/compare/). |
27 |
| - * Wait for feedback or merge. |
| 31 | +* Push to your fork and [submit a pull request](https://github.com/yoanm/php-jsonrpc-http-server-swagger-doc-sdk/compare/). |
| 32 | +* Wait for feedback or merge. |
| 33 | + |
| 34 | +Some stuff that will increase your pull request's acceptance: |
28 | 35 |
|
29 |
| - Some stuff that will increase your pull request's acceptance: |
30 |
| - * Write tests. |
31 |
| - * Follow PSR-2 coding style. |
32 |
| - * Write good commit messages. |
33 |
| - * Do not rebase or squash your commits when a review has been made. |
| 36 | +* Write tests. |
| 37 | +* Follow PSR-2 coding style. |
| 38 | +* Write good commit messages. |
| 39 | +* Do not rebase or squash your commits when a review has been made. |
0 commit comments