Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cwd and append source path to destination path #6

Open
dgieselaar opened this issue Apr 1, 2013 · 6 comments
Open

Comments

@dgieselaar
Copy link

Currently, there's no way to change the cwd when using grunt-text-replace, and the destination ignores the path of the source file relative to the cwd, which makes it cumbersome to do a replace when using a more complex file structure.

If you want to, I'll submit a pull request, I've already got it working on my project.

@yoniholmes
Copy link
Owner

Hi Dario,

Thanks for getting in touch. Yeah, I'll consider your pull request if you
want to send it through. Thanks again for pointing this out.

Cheers,

Jonathan

On 1 April 2013 20:10, Dario Gieselaar notifications@github.com wrote:

Currently, there's no way to change the cwd when using grunt-text-replace,
and the destination ignores the path of the source file relative to the
cwd, which makes it cumbersome to do a replace when using a more complex
file structure.

If you want to, I'll submit a pull request, I've already got it working on
my project.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6
.

@dgieselaar
Copy link
Author

Here we go: #7.

@yoniholmes
Copy link
Owner

Thanks Dario. Sorry for the delay in replying - just got back from holiday. I'll take a look this weekend and will give you an update once done.

Thanks again,

Cheers,

Jonathan

@dgieselaar
Copy link
Author

There's probably a better way to do change the cwd, I think there's built-in support in grunt for it somewhere. Will take a look at it asap.

@yoniholmes
Copy link
Owner

Ok Dario, let me know how you go. Were you intending to provide a new pull request then? Cheers, Jonathan

@dgieselaar
Copy link
Author

Definitely, hopefully later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants