Skip to content

Commit a5a2ffe

Browse files
andy31415andreilitvinbzbarsky-apple
authored andcommitted
Remove python_lib build&test out of darwin build steps (project-chip#35980)
* Remove python_lib build step completely. After project-chip#34892 this build is a noop so we do not benefit from running the build a 2nd time. This should save some CI time. * Update .github/workflows/build.yaml Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Add back comments --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
1 parent 90b6caf commit a5a2ffe

File tree

1 file changed

+11
-18
lines changed

1 file changed

+11
-18
lines changed

.github/workflows/build.yaml

+11-18
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ jobs:
375375
scripts/build_python_device.sh --chip_detail_logging true
376376
377377
build_darwin:
378-
name: Build on Darwin (clang, python_lib, simulated)
378+
name: Build on Darwin (clang, simulated)
379379
runs-on: macos-13
380380
if: github.actor != 'restyled-io[bot]'
381381

@@ -402,27 +402,20 @@ jobs:
402402
CHIP_ROOT_PATH=examples/placeholder/linux
403403
CHIP_ROOT_PATH="$CHIP_ROOT_PATH" BUILD_TYPE="$BUILD_TYPE" scripts/build/gn_gen.sh --args="$GN_ARGS"
404404
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
405-
- name: Setup Build, Run Build and Run Tests
405+
- name: Setup Build, Run Build and Run Tests (asan + target_os=all)
406406
# We can't enable leak checking here in LSAN_OPTIONS, because on
407407
# Darwin that's only supported with a new enough clang, and we're
408408
# not building with the pigweed clang here.
409+
env:
410+
BUILD_TYPE: default
409411
run: |
410-
for BUILD_TYPE in default python_lib; do
411-
case $BUILD_TYPE in
412-
# We want to build various standalone example apps
413-
# (similar to what examples-linux-standalone.yaml
414-
# does), so use target_os="all" to get those picked
415-
# up as part of the "unified" build. But then to
416-
# save CI resources we want to exclude the
417-
# "host clang" build, which uses the pigweed
418-
# clang.
419-
"default") GN_ARGS='target_os="all" is_asan=true enable_host_clang_build=false';;
420-
esac
421-
BUILD_TYPE=$BUILD_TYPE scripts/build/gn_gen.sh --args="$GN_ARGS chip_data_model_check_die_on_failure=true" --export-compile-commands
422-
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
423-
BUILD_TYPE=$BUILD_TYPE scripts/tests/gn_tests.sh
424-
done
425-
- name: Ensure codegen is done for sanitize
412+
# We want to build various standalone example apps similar to what examples-linux-standalone.yaml
413+
# does), so use target_os="all" to get those picked up as part of the "unified" build. But then
414+
# to save CI resources we want to exclude the "host clang" build, which uses the pigweed clang.
415+
scripts/build/gn_gen.sh --args='target_os="all" is_asan=true enable_host_clang_build=false chip_data_model_check_die_on_failure=true' --export-compile-commands
416+
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
417+
scripts/tests/gn_tests.sh
418+
- name: Ensure codegen is done for default
426419
run: |
427420
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/default"
428421
- name: Clang-tidy validation

0 commit comments

Comments
 (0)