Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit bde1a2e

Browse files
j-ororkerestyled-commitstehampson
authored andcommittedDec 11, 2024
[Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24 python test modules (project-chip#35632)
* [Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24: - Created CADMIN_1_22 python test module following steps in PR here: - Created CADMIN_1_24 python test module following steps in PR here: - Removed following yaml test modules: -- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml * Restyled by autopep8 * Updating TC_CADMIN_1_22 and TC_CADMIN_1_24: - Resolved linting issues * Created TC_CADMIN_1_22_24 test module: - Merged TC_CADMIN_1_24 and TC_CADMIN_1_22 standalone test modules into a single test module - Found enum for window closed value and replaced it in the tests - Removed generate_unique_value and AttemptCommission functions - Updated CI arguments format to YAML'esque format * Restyled by autopep8 * Updated TC_CADMIN_1_22_24: - Renamed class to TC_CADMIN_1_22_24 * Updating TC_CADMIN_1_22_24: - Resolving lint errors * Update TC_CADMIN_1_22_24.py Updated to include dependency location change for matter_testing support module * Updated TC_CADMIN_1_22_24.py: - Resolved issues with CI args in TC_CADMIN_1_22_24 test module - Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json * Updating TC_CADMIN_1_22_24 test module: - Resolving comments from tehampson as these were needed changes to be made -- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure -- Resolving copy paste error in TC_CADMIN_1_4 test -- Made comments cleaner by rewording to include what the error code was referring too * Update TC_CADMIN_1_22_24 test module: - Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning * Restyled by autopep8 * Update TC_CADMIN_1_22_24.py - Unnesting asserts from if statements * Update src/python_testing/TC_CADMIN_1_22_24.py - Adding this suggested change from Terrence into the code, as it does make the code much cleaner Co-authored-by: Terence Hampson <thampson@google.com> * Update TC_CADMIN_1_22_24.py -Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read. * Restyled by autopep8 * Updated TC_CADMIN_1_22_24 test module: - Removed unneccessary await from asserts * Restyled by autopep8 --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Terence Hampson <thampson@google.com>
1 parent 2df71b4 commit bde1a2e

File tree

6 files changed

+179
-650
lines changed

6 files changed

+179
-650
lines changed
 

‎src/app/tests/suites/certification/Test_TC_CADMIN_1_21.yaml

-123
This file was deleted.

‎src/app/tests/suites/certification/Test_TC_CADMIN_1_22.yaml

-199
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.