Skip to content

Commit 62d1a6a

Browse files
authored
Minor fixes for zarr.codecs.numcodecs (#3459)
* fix gzip typo * fix failing example at top of zarr-codecs-numcodecs * fix failing tests
1 parent a830d02 commit 62d1a6a

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

docs/user-guide/config.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ This is the current default configuration::
6262
'numcodecs.delta': 'zarr.codecs.numcodecs.Delta',
6363
'numcodecs.fixedscaleoffset': 'zarr.codecs.numcodecs.FixedScaleOffset',
6464
'numcodecs.fletcher32': 'zarr.codecs.numcodecs.Fletcher32',
65-
'numcodecs.gZip': 'zarr.codecs.numcodecs.GZip',
65+
'numcodecs.gzip': 'zarr.codecs.numcodecs.GZip',
6666
'numcodecs.jenkins_lookup3': 'zarr.codecs.numcodecs.JenkinsLookup3',
6767
'numcodecs.lz4': 'zarr.codecs.numcodecs.LZ4',
6868
'numcodecs.lzma': 'zarr.codecs.numcodecs.LZMA',

src/zarr/codecs/numcodecs/_codecs.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
44
These codecs were previously defined in :py:mod:`numcodecs`, and have now been moved to `zarr`.
55
6+
>>> import numpy as np
67
>>> import zarr
78
>>> import zarr.codecs.numcodecs as numcodecs
89
>>>
@@ -11,9 +12,9 @@
1112
... shape=(1024, 1024),
1213
... chunks=(64, 64),
1314
... dtype="uint32",
14-
... filters=[numcodecs.zarr3.Delta()],
15-
... compressors=[numcodecs.zarr3.BZ2(level=5)])
16-
>>> array[:] = np.arange(*array.shape).astype(array.dtype)
15+
... filters=[numcodecs.Delta(dtype="uint32")],
16+
... compressors=[numcodecs.BZ2(level=5)])
17+
>>> array[:] = np.arange(np.prod(array.shape), dtype=array.dtype).reshape(*array.shape)
1718
1819
.. note::
1920

src/zarr/core/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def enable_gpu(self) -> ConfigSet:
138138
"numcodecs.delta": "zarr.codecs.numcodecs.Delta",
139139
"numcodecs.fixedscaleoffset": "zarr.codecs.numcodecs.FixedScaleOffset",
140140
"numcodecs.fletcher32": "zarr.codecs.numcodecs.Fletcher32",
141-
"numcodecs.gZip": "zarr.codecs.numcodecs.GZip",
141+
"numcodecs.gzip": "zarr.codecs.numcodecs.GZip",
142142
"numcodecs.jenkins_lookup3": "zarr.codecs.numcodecs.JenkinsLookup3",
143143
"numcodecs.pcodec": "zarr.codecs.numcodecs.PCodec",
144144
"numcodecs.packbits": "zarr.codecs.numcodecs.PackBits",

tests/test_codecs/test_numcodecs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def codec_conf() -> Iterator[Any]:
3535
"numcodecs.delta": "zarr.codecs.numcodecs.Delta",
3636
"numcodecs.fixedscaleoffset": "zarr.codecs.numcodecs.FixedScaleOffset",
3737
"numcodecs.fletcher32": "zarr.codecs.numcodecs.Fletcher32",
38-
"numcodecs.gZip": "zarr.codecs.numcodecs.GZip",
38+
"numcodecs.gzip": "zarr.codecs.numcodecs.GZip",
3939
"numcodecs.jenkinslookup3": "zarr.codecs.numcodecs.JenkinsLookup3",
4040
"numcodecs.pcodec": "zarr.codecs.numcodecs.PCodec",
4141
"numcodecs.packbits": "zarr.codecs.numcodecs.PackBits",

tests/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def test_config_defaults_set() -> None:
8686
"numcodecs.delta": "zarr.codecs.numcodecs.Delta",
8787
"numcodecs.fixedscaleoffset": "zarr.codecs.numcodecs.FixedScaleOffset",
8888
"numcodecs.fletcher32": "zarr.codecs.numcodecs.Fletcher32",
89-
"numcodecs.gZip": "zarr.codecs.numcodecs.GZip",
89+
"numcodecs.gzip": "zarr.codecs.numcodecs.GZip",
9090
"numcodecs.jenkins_lookup3": "zarr.codecs.numcodecs.JenkinsLookup3",
9191
"numcodecs.pcodec": "zarr.codecs.numcodecs.PCodec",
9292
"numcodecs.packbits": "zarr.codecs.numcodecs.PackBits",

0 commit comments

Comments
 (0)