Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Host] Abandon/dead letter message #356

Closed
EtherZa opened this issue Dec 31, 2024 · 3 comments
Closed

[Host] Abandon/dead letter message #356

EtherZa opened this issue Dec 31, 2024 · 3 comments

Comments

@EtherZa
Copy link
Contributor

EtherZa commented Dec 31, 2024

SMB does not provide an out of the box way to dead letter messages for the transports that support it. It is currently possible for RabbitMQ through a nack in a IConsumerErrorHandler, but not for Azure Service Bus.

ASB messages that throw an exception will be retried n times before finally being sent to the DLQ.

If an exception can be determined to be non-transient (and therefore will not be resolved in a subsequent execution), it would be beneficial to send the message to the DLQ immediately.

EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Dec 31, 2024
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
@zarusz
Copy link
Owner

zarusz commented Dec 31, 2024

Yes, we could add this as an asb transport specific feature. Perhaps even unify across all transports (but not sure about if it's worth unifying).

@zarusz
Copy link
Owner

zarusz commented Dec 31, 2024

What would be good is also gave the ability to set application properties (headers) from the error handler or consumer when message is abandoned on the asb transports. This helps to convey partially completed work and have it available for the next message retry.

EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 1, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 1, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 1, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 1, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 1, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
zarusz pushed a commit that referenced this issue Jan 1, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
@zarusz
Copy link
Owner

zarusz commented Jan 1, 2025

Closed via #357.

Also see another feature request: #358

@zarusz zarusz closed this as completed Jan 1, 2025
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 2, 2025
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 2, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 3, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Jan 3, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
zarusz pushed a commit that referenced this issue Jan 3, 2025
Signed-off-by: Richard Pringle <richardpringle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants