Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: ethernet: eth_stm32_hal: support get_config #84898

Closed
clamattia opened this issue Jan 30, 2025 · 2 comments · Fixed by #86315
Closed

drivers: ethernet: eth_stm32_hal: support get_config #84898

clamattia opened this issue Jan 30, 2025 · 2 comments · Fixed by #86315
Assignees
Labels
area: Ethernet Enhancement Changes/Updates/Additions to existing features Good first issue Good for a first time contributor to take platform: STM32 ST Micro STM32

Comments

@clamattia
Copy link
Contributor

Is your enhancement proposal related to a problem? Please describe.
There is currently no good way to query the configuration of the Ethernet on this driver (to my knowledge).

Describe the solution you'd like
Please implement int(* get_config )(const struct device *dev, enum ethernet_config_type type, struct ethernet_config *config) for the eth_stm32_hal-driver.

Describe alternatives you've considered
None

Additional context
None

@clamattia clamattia added the Enhancement Changes/Updates/Additions to existing features label Jan 30, 2025
@erwango erwango added the Good first issue Good for a first time contributor to take label Jan 30, 2025
@ramram885
Copy link
Contributor

Hello community,

I'm just new to zephyr and open source software development. Recently started to study about network drivers development too.

In zephyr project, I could see that many of the ethernet drivers have implemented only set_config() function in the driver code.
I couldn't find much drivers that has implemented get_config() function. Can any one please explain reason behind this.

And I could see that many drivers have implementation for get_capabilities(). Is the get_capabilities() function itself enough to fulfill the implementation of get_config()?. Because I am thinking that, If we implement the get_config(), the functionality will be more or less same as get_capabilities().
Is the understanding is correct or not?

Thanks!

@erwango
Copy link
Member

erwango commented Feb 17, 2025

@ramram885 Please open a dedicated discussion for you questions or alternatively engage on Zephyr Discord the network channel.

ramram885 added a commit to ramram885/zephyr that referenced this issue Feb 25, 2025
Implementation of get_config() api added
Fixes: zephyrproject-rtos#84898

Signed-off-by: Ram Mahesh <rammaheshram1234@gmail.com>
ramram885 added a commit to ramram885/zephyr that referenced this issue Feb 26, 2025
Implementation of get_config() api added
Fixes: zephyrproject-rtos#84898

Signed-off-by: Ram Mahesh <rammaheshram1234@gmail.com>
ramram885 added a commit to ramram885/zephyr that referenced this issue Feb 26, 2025
Implementation of get_config() api added
Fixes: zephyrproject-rtos#84898

Signed-off-by: Ram Mahesh <rammaheshram1234@gmail.com>
ramram885 added a commit to ramram885/zephyr that referenced this issue Mar 7, 2025
Implementation of get_config() api added
Fixes: zephyrproject-rtos#84898

Signed-off-by: Ram Mahesh <rammaheshram1234@gmail.com>
ramram885 added a commit to ramram885/zephyr that referenced this issue Mar 7, 2025
Implementation of get_config() api added
Fixes: zephyrproject-rtos#84898

Signed-off-by: Ram Mahesh <rammaheshram1234@gmail.com>
ramram885 added a commit to ramram885/zephyr that referenced this issue Mar 15, 2025
Implementation of get_config() api added
Fixes: zephyrproject-rtos#84898

Signed-off-by: Ram Mahesh <rammaheshram1234@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Ethernet Enhancement Changes/Updates/Additions to existing features Good first issue Good for a first time contributor to take platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants