Skip to content

Commit 0a8021d

Browse files
committed
Merge branch 'master' of https://github.com/zigbee-alliance/distributed-compliance-ledger into fix/model-fields
2 parents 26ebd81 + fe499d4 commit 0a8021d

19 files changed

+107
-68
lines changed

docs/transactions.md

+44-43
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ an Account or sign the request.
4747
- CLI 1: Is connected to the network of nodes. Doesn't have access to private keys.
4848
- CLI 2: Stores private key. Does not have a connection to the network of nodes.
4949
- Build transaction by CLI 1: `dcld tx ... --generate-only`
50-
- Fetch `account number` and `sequence` by CLI 1: `dcld query auth account --address <address>`
50+
- Fetch `account-number` and `sequence` by CLI 1: `dcld query auth account --address <address>`
5151
- Sign transaction by CLI 2: `dcld tx sign txn.json --from <from> --account-number <int> --sequence <int> --gas "auto" --offline --output-document txn.json`
5252
- Broadcast transaction by CLI 1: `dcld tx broadcast txn.json`
5353
- To get the actual result of transaction, `dcld query tx=txHash` call must be executed, where `txHash` is the hash of previously executed transaction.
@@ -1356,16 +1356,16 @@ Should be sent to trusted nodes only.
13561356

13571357
### E2E (NOC)
13581358

1359-
#### ADD_NOC_ROOT
1359+
#### ADD_NOC_ROOT (RCAC)
13601360

13611361
**Status: Implemented**
13621362

1363-
This transaction adds a NOC root certificate owned by the Vendor.
1363+
This transaction adds a NOC root certificate (RCAC) owned by the Vendor.
13641364

13651365
- Who can send
13661366
- Vendor account
13671367
- Parameters:
1368-
- cert: `string` - The NOC Root Certificate, encoded in X.509v3 PEM format. Can be a PEM string or a file path.
1368+
- cert: `string` - The NOC Root Certificate (RCAC), encoded in X.509v3 PEM format. Can be a PEM string or a file path.
13691369
- schemaVersion: `optional(uint16)` - Certificate's schema version to support backward/forward compatability(default 0)
13701370
- In State:
13711371
- `pki/ApprovedCertificates/value/<Subject>/<SubjectKeyID>`
@@ -1375,27 +1375,27 @@ This transaction adds a NOC root certificate owned by the Vendor.
13751375
- CLI Command:
13761376
- `dcld tx pki add-noc-x509-root-cert --certificate=<string-or-path> --from=<account>`
13771377
- Validation:
1378-
- the provided certificate must be a root certificate:
1378+
- the provided certificate must be a root certificate (RCAC):
13791379
- `Issuer` == `Subject`
13801380
- `Authority Key Identifier` == `Subject Key Identifier`
13811381
- no existing certificate with the same `<Certificate's Issuer>:<Certificate's Serial Number>` combination.
13821382
- if certificates with the same `<Certificate's Subject>:<Certificate's Subject Key ID>` combination already exist:
1383-
- the existing certificate must be NOC root certificate
1383+
- the existing certificate must be NOC root certificate (RCAC)
13841384
- the sender's VID must match the `vid` field of the existing certificates.
13851385
- the signature (self-signature) and expiration date must be valid.
13861386

1387-
#### REVOKE_NOC_ROOT
1387+
#### REVOKE_NOC_ROOT (RCAC)
13881388

13891389
**Status: Implemented**
13901390

1391-
This transaction revokes a NOC root certificate owned by the Vendor.
1392-
Revoked NOC root certificates can be re-added using the [ADD_NOC_ROOT](#add_noc_root) transaction.
1391+
This transaction revokes a NOC root certificate (RCAC) owned by the Vendor.
1392+
Revoked NOC root certificates (RCACs) can be re-added using the [ADD_NOC_ROOT](#add_noc_root-(rcac)) transaction.
13931393

13941394
Revocation works as a soft-delete, meaning that the certificates are not entirely removed but moved from the approved list to the revoked list.
13951395
Revoked certificates can be retrieved by using the [GET_REVOKED_CERT](#get_revoked_cert) query.
13961396

13971397
- Who can send: Vendor account
1398-
- Vid field associated with the corresponding NOC root certificate on the ledger must be equal to the Vendor account's VID.
1398+
- Vid field associated with the corresponding NOC root certificate (RCAC) on the ledger must be equal to the Vendor account's VID.
13991399
- Parameters:
14001400
- subject: `string` - base64 encoded subject DER sequence bytes of the certificate.
14011401
- subject_key_id: `string` - certificate's `Subject Key Id` in hex string format, e.g., `5A:88:0E:6C:36:53:D0:7F:B0:89:71:A3:F4:73:79:09:30:E6:2B:DB`.
@@ -1409,19 +1409,19 @@ Revoked certificates can be retrieved by using the [GET_REVOKED_CERT](#get_revok
14091409
- CLI command:
14101410
- `dcld tx pki revoke-noc-x509-root-cert --subject=<base64 string> --subject-key-id=<hex string> --serial-number=<string> --info=<string> --time=<int64> --revoke-child=<bool> --from=<account>`
14111411
- Validation:
1412-
- a NOC Root Certificate with the provided `subject` and `subject_key_id` must exist in the ledger.
1412+
- a NOC Root Certificate (RCAC) with the provided `subject` and `subject_key_id` must exist in the ledger.
14131413

1414-
#### REMOVE_NOC_ROOT
1414+
#### REMOVE_NOC_ROOT (RCAC)
14151415

14161416
**Status: Implemented**
14171417

1418-
This transaction completely removes the given NOC root certificate owned by the Vendor from the ledger.
1419-
Removed NOC root certificates can be re-added using the [ADD_NOC_ROOT](#add_noc_root) transaction.
1418+
This transaction completely removes the given NOC root certificate (RCAC) owned by the Vendor from the ledger.
1419+
Removed NOC root certificates (RCACs) can be re-added using the [ADD_NOC_ROOT](#add_noc_root-(rcac)) transaction.
14201420

14211421
- Who can send: Vendor account
14221422
- Vid field associated with the corresponding NOC certificate on the ledger must be equal to the Vendor account's VID.
14231423
- Validation:
1424-
- a NOC Root Certificate with the provided `subject` and `subject_key_id` must exist in the ledger.
1424+
- a NOC Root Certificate (RCAC) with the provided `subject` and `subject_key_id` must exist in the ledger.
14251425
- Parameters:
14261426
- subject: `string` - base64 encoded subject DER sequence bytes of the certificate.
14271427
- subject_key_id: `string` - certificate's `Subject Key Id` in hex string format, e.g., `5A:88:0E:6C:36:53:D0:7F:B0:89:71:A3:F4:73:79:09:30:E6:2B:DB`.
@@ -1431,11 +1431,11 @@ Removed NOC root certificates can be re-added using the [ADD_NOC_ROOT](#add_noc_
14311431

14321432

14331433

1434-
#### ADD_NOC_ICA
1434+
#### ADD_NOC_ICA (ICAC)
14351435

14361436
**Status: Implemented**
14371437

1438-
This transaction adds a NOC ICA certificate owned by the Vendor signed by a chain of certificates which must be
1438+
This transaction adds a NOC ICA certificate (ICAC) owned by the Vendor signed by a chain of certificates which must be
14391439
already present on the ledger.
14401440

14411441
- Who can send: Vendor account
@@ -1463,12 +1463,12 @@ already present on the ledger.
14631463
- CLI Command:
14641464
- `dcld tx pki add-noc-x509-ica-cert --certificate=<string-or-path> --from=<account>`
14651465

1466-
#### REVOKE_NOC_ICA
1466+
#### REVOKE_NOC_ICA (ICAC)
14671467

14681468
**Status: Implemented**
14691469

1470-
This transaction revokes a NOC ICA certificate owned by the Vendor.
1471-
Revoked NOC ICA certificates can be re-added using the [ADD_NOC_ICA](#add_noc_ica) transaction.
1470+
This transaction revokes a NOC ICA certificate (ICAC) owned by the Vendor.
1471+
Revoked NOC ICA certificates (ICACs) can be re-added using the [ADD_NOC_ICA](#add_noc_ica-(icac)) transaction.
14721472

14731473
Revocation works as a soft-delete, meaning that the certificates are not entirely removed but moved from the approved list to the revoked list.
14741474
Revoked certificates can be retrieved by using the [GET_REVOKED_CERT](#get_revoked_cert) query.
@@ -1489,17 +1489,17 @@ Revoked certificates can be retrieved by using the [GET_REVOKED_CERT](#get_revok
14891489
- CLI command:
14901490
- `dcld tx pki revoke-noc-x509-ica-cert --subject=<base64 string> --subject-key-id=<hex string> --serial-number=<string> --info=<string> --time=<int64> --revoke-child=<bool> --from=<account>`
14911491

1492-
#### REMOVE_NOC_ICA
1492+
#### REMOVE_NOC_ICA (ICAC)
14931493

14941494
**Status: Implemented**
14951495

1496-
This transaction completely removes the given NOC ICA owned by the Vendor from the ledger.
1497-
Removed NOC ICA certificates can be re-added using the [ADD_NOC_ICA](#add_noc_ica) transaction.
1496+
This transaction completely removes the given NOC ICA (ICAC) owned by the Vendor from the ledger.
1497+
Removed NOC ICA certificates (ICACs) can be re-added using the [ADD_NOC_ICA](#add_noc_ica-(icac)) transaction.
14981498

14991499
- Who can send: Vendor account
15001500
- Vid field associated with the corresponding NOC certificate on the ledger must be equal to the Vendor account's VID.
15011501
- Validation:
1502-
- a NOC ICA Certificate with the provided `subject` and `subject_key_id` must exist in the ledger.
1502+
- a NOC ICA Certificate (ICAC) with the provided `subject` and `subject_key_id` must exist in the ledger.
15031503
- Parameters:
15041504
- subject: `string` - base64 encoded subject DER sequence bytes of the certificate.
15051505
- subject_key_id: `string` - certificate's `Subject Key Id` in hex string format, e.g., `5A:88:0E:6C:36:53:D0:7F:B0:89:71:A3:F4:73:79:09:30:E6:2B:DB`.
@@ -1508,14 +1508,14 @@ Removed NOC ICA certificates can be re-added using the [ADD_NOC_ICA](#add_noc_ic
15081508
- `dcld tx pki remove-noc-x509-ica-cert --subject=<base64 string> --subject-key-id=<hex string> --from=<account>`
15091509

15101510

1511-
#### GET_NOC_ROOT_BY_VID
1511+
#### GET_NOC_ROOT_BY_VID (RCACs)
15121512

15131513
**Status: Implemented**
15141514

1515-
Retrieve NOC root certificates associated with a specific VID.
1515+
Retrieve NOC root certificates (RCACs) associated with a specific VID.
15161516

1517-
Revoked NOC root certificates are not returned.
1518-
Use [GET_ALL_REVOKED_NOC_ROOT](#get_revoked_noc_root) to get a list of all revoked NOC root certificates.
1517+
Revoked NOC root certificates (RCACs) are not returned.
1518+
Use [GET_ALL_REVOKED_NOC_ROOT](#get_all_revoked_noc_root-(rcacs)) to get a list of all revoked NOC root certificates (RCACs).
15191519

15201520
- Who can send: Any account
15211521
- Parameters:
@@ -1525,15 +1525,16 @@ Use [GET_ALL_REVOKED_NOC_ROOT](#get_revoked_noc_root) to get a list of all revok
15251525
- REST API:
15261526
- GET `/dcl/pki/noc-root-certificates/{vid}`
15271527

1528-
#### GET_NOC_BY_VID_AND_SKID
1528+
#### GET_NOC_BY_VID_AND_SKID (RCACs/ICACs)
15291529

15301530
**Status: Implemented**
15311531

1532-
Retrieve NOC (Root/ICA) certificates associated with a specific VID and subject key ID.
1532+
Retrieve NOC (Root/ICA) certificates (RCACs/ICACs) associated with a specific VID and subject key ID.
15331533
This request also returns the Trust Quotient (TQ) value of the certificate
15341534

15351535
Revoked NOC certificates are not returned.
1536-
Use [GET_ALL_REVOKED_NOC_ROOT](#get_revoked_noc_root) to get a list of all revoked NOC root certificates.
1536+
Use [GET_ALL_REVOKED_NOC_ROOT](#get_all_revoked_noc_root-(rcacs)) to get a list of all revoked NOC root certificates.
1537+
Use [GET_ALL_REVOKED_CERT](#get_all_revoked_certs) to get a list of all revoked certificates (including ICACs).
15371538

15381539
- Who can send: Any account
15391540
- Parameters:
@@ -1544,11 +1545,11 @@ Use [GET_ALL_REVOKED_NOC_ROOT](#get_revoked_noc_root) to get a list of all revok
15441545
- REST API:
15451546
- GET `/dcl/pki/noc-certificates/{vid}/{subject_key_id}`
15461547

1547-
#### GET_NOC_ICA_BY_VID
1548+
#### GET_NOC_ICA_BY_VID (ICACs)
15481549

15491550
**Status: Implemented**
15501551

1551-
Retrieve NOC ICA certificates associated with a specific VID.
1552+
Retrieve NOC ICA certificates (ICACs) associated with a specific VID.
15521553

15531554
Revoked certificates are not returned.
15541555
Use [GET_ALL_REVOKED_CERT](#get_all_revoked_certs) to get a list of all revoked certificates.
@@ -1561,11 +1562,11 @@ Use [GET_ALL_REVOKED_CERT](#get_all_revoked_certs) to get a list of all revoked
15611562
- REST API:
15621563
- GET `/dcl/pki/noc-ica-certificates/{vid}`
15631564

1564-
#### GET_REVOKED_NOC_ROOT
1565+
#### GET_REVOKED_NOC_ROOT (RCAC)
15651566

15661567
**Status: Implemented**
15671568

1568-
Gets a revoked NOC root certificate by the given subject and subject key ID attributes.
1569+
Gets a revoked NOC root certificate (RCAC) by the given subject and subject key ID attributes.
15691570

15701571
Revocation works as a soft-delete, meaning that the certificates are not entirely removed but moved from the approved list to the revoked list.
15711572

@@ -1577,14 +1578,14 @@ Revocation works as a soft-delete, meaning that the certificates are not entirel
15771578
- REST API:
15781579
- GET `/dcl/pki/revoked-noc-root-certificates/{subject}/{subject_key_id}`
15791580

1580-
#### GET_ALL_NOC_ROOT
1581+
#### GET_ALL_NOC_ROOT (RCACs)
15811582

15821583
**Status: Implemented**
15831584

1584-
Retrieve a list of all of NOC root certificates.
1585+
Retrieve a list of all of NOC root certificates (RCACs).
15851586

1586-
Revoked NOC root certificates are not returned.
1587-
Use [GET_ALL_REVOKED_NOC_ROOT](#get_revoked_noc_root) to get a list of all revoked NOC root certificates.
1587+
Revoked NOC root certificates (RCACs) are not returned.
1588+
Use [GET_ALL_REVOKED_NOC_ROOT](#get_all_revoked_noc_root-(rcacs)) to get a list of all revoked NOC root certificates (RCACs).
15881589

15891590
- Who can send: Any account
15901591
- Parameters:
@@ -1594,11 +1595,11 @@ Use [GET_ALL_REVOKED_NOC_ROOT](#get_revoked_noc_root) to get a list of all revok
15941595
- REST API:
15951596
- GET `/dcl/pki/noc-root-certificates`
15961597

1597-
#### GET_ALL_NOC_ICA
1598+
#### GET_ALL_NOC_ICA (ICACs)
15981599

15991600
**Status: Implemented**
16001601

1601-
Retrieve a list of all of NOC ICA certificates
1602+
Retrieve a list of all of NOC ICA certificates (ICACs).
16021603

16031604
Revoked certificates are not returned.
16041605
Use [GET_ALL_REVOKED_CERT](#get_all_revoked_certs) to get a list of all revoked certificates.
@@ -1611,9 +1612,9 @@ Use [GET_ALL_REVOKED_CERT](#get_all_revoked_certs) to get a list of all revoked
16111612
- REST API:
16121613
- GET `/dcl/pki/noc-ica-certificates`
16131614

1614-
#### GET_ALL_REVOKED_NOC_ROOT
1615+
#### GET_ALL_REVOKED_NOC_ROOT (RCACs)
16151616

1616-
Gets all revoked NOC root certificates.
1617+
Gets all revoked NOC root certificates (RCACs).
16171618

16181619
Revocation works as a soft-delete, meaning that the certificates are not entirely removed but moved from the approved list to the revoked list.
16191620

integration_tests/cli/pki-add-vendor-x509-certificates.sh

+6
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ check_response "$result" "\"subject\": \"$intermediate_cert_with_vid_65521_subje
5555
check_response "$result" "\"subjectKeyId\": \"$intermediate_cert_with_vid_65521_subject_key_id\""
5656
check_response "$result" "\"serialNumber\": \"$intermediate_cert_with_vid_65521_serial_number\""
5757

58+
echo "Request intermediate certificate by subject=$intermediate_cert_with_vid_65521_subject and skid=$intermediate_cert_with_vid_65521_subject_key_id."
59+
result=$(dcld query pki x509-cert --subject="$intermediate_cert_with_vid_65521_subject" --subject-key-id="$intermediate_cert_with_vid_65521_subject_key_id")
60+
echo $result | jq
61+
check_response "$result" "\"serialNumber\": \"$intermediate_cert_with_vid_65521_serial_number\""
62+
check_response "$result" "\"vid\": $intermediate_cert_with_vid_65521_vid"
63+
5864
echo "Try to add an intermediate certificate with vid=$intermediate_cert_with_vid_65522_vid by $vendor_account_65521 with vid=$vendor_vid_65521"
5965
result=$(echo "$passphrase" | dcld tx pki add-x509-cert --certificate="$intermediate_cert_with_vid_65522_path" --from $vendor_account_65521 --yes)
6066
result=$(get_txn_result "$result")

integration_tests/constants/constants.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ FGE90Ic1XvCLrgHkxpqPxz2sjH39MB8GA1UdIwQYMBaAFHhc5wW4a49Ob8eTqmDL
361361
Q+ppaILVMAoGCCqGSM49BAMCA0gAMEUCIQDfwJ3oS/qVbWDW/vTirREL3iIqMogw
362362
pn4/F7keUYUaeAIgce2XGOSIsrjPlUQ1zj/zLqUFVhQ8TyycBaIK8z7Uytk=
363363
-----END CERTIFICATE-----`
364-
364+
PAICertWithNumericVidVid = 65522
365365
PAICertWithNumericVidSubject = "MDAxGDAWBgNVBAMMD01hdHRlciBUZXN0IFBBSTEUMBIGCisGAQQBgqJ8AgEMBEZGRjI="
366366
PAICertWithNumericVidSubjectKeyID = "61:3D:D0:87:35:5E:F0:8B:AE:01:E4:C6:9A:8F:C7:3D:AC:8C:7D:FD"
367367

integration_tests/grpc_rest/pki/helpers.go

+1
Original file line numberDiff line numberDiff line change
@@ -2151,4 +2151,5 @@ func Demo(suite *utils.TestSuite) {
21512151
// Check there is only one approved intermediate certificate
21522152
certs, _ = GetX509Cert(suite, testconstants.PAICertWithNumericVidSubject, testconstants.PAICertWithNumericVidSubjectKeyID)
21532153
require.Equal(suite.T, 1, len(certs.Certs))
2154+
require.Equal(suite.T, int32(testconstants.PAICertWithNumericVidVid), certs.Certs[0].Vid)
21542155
}

x/pki/client/cli/query_noc_certificates.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
func CmdListNocIcaCertificates() *cobra.Command {
1616
cmd := &cobra.Command{
1717
Use: "all-noc-x509-ica-certs",
18-
Short: "Gets all NOC ICA certificates",
18+
Short: "Gets all NOC ICA certificates (ICACs)",
1919
RunE: func(cmd *cobra.Command, args []string) error {
2020
clientCtx := client.GetClientContextFromCmd(cmd)
2121

@@ -49,7 +49,7 @@ func CmdShowNocIcaCertificates() *cobra.Command {
4949
var vid int32
5050
cmd := &cobra.Command{
5151
Use: "noc-x509-ica-certs",
52-
Short: "Gets NOC ICA certificates by VID",
52+
Short: "Gets NOC ICA certificates (ICACs) by VID",
5353
Args: cobra.ExactArgs(0),
5454
RunE: func(cmd *cobra.Command, args []string) (err error) {
5555
clientCtx := client.GetClientContextFromCmd(cmd)

x/pki/client/cli/query_noc_certificates_by_vid_skid.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func CmdShowNocCertificatesByVidAndSkid() *cobra.Command {
1717

1818
cmd := &cobra.Command{
1919
Use: "noc-x509-certs",
20-
Short: "Gets NOC certificates by VID and Skid",
20+
Short: "Gets NOC (Root/ICA) certificates (RCAC/ICAC) by VID and Skid",
2121
Args: cobra.ExactArgs(0),
2222
RunE: func(cmd *cobra.Command, args []string) (err error) {
2323
clientCtx := client.GetClientContextFromCmd(cmd)

x/pki/client/cli/query_noc_root_certificates.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
func CmdListNocRootCertificates() *cobra.Command {
1515
cmd := &cobra.Command{
1616
Use: "all-noc-x509-root-certs",
17-
Short: "Gets all NOC root certificates",
17+
Short: "Gets all NOC root certificates (RCACs)",
1818
RunE: func(cmd *cobra.Command, args []string) error {
1919
clientCtx := client.GetClientContextFromCmd(cmd)
2020

@@ -51,7 +51,7 @@ func CmdShowNocRootCertificates() *cobra.Command {
5151

5252
cmd := &cobra.Command{
5353
Use: "noc-x509-root-certs",
54-
Short: "Gets NOC root certificates by VID",
54+
Short: "Gets NOC root certificates (RCACs) by VID",
5555
Args: cobra.ExactArgs(0),
5656
RunE: func(cmd *cobra.Command, args []string) (err error) {
5757
clientCtx := client.GetClientContextFromCmd(cmd)

x/pki/client/cli/query_revoked_noc_root_certificates.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
func CmdListRevokedNocRootCertificates() *cobra.Command {
1616
cmd := &cobra.Command{
1717
Use: "all-revoked-noc-x509-root-certs",
18-
Short: "Gets all revoked noc root certificates",
18+
Short: "Gets all revoked noc root certificates (RCACs)",
1919
RunE: func(cmd *cobra.Command, args []string) error {
2020
clientCtx := client.GetClientContextFromCmd(cmd)
2121

@@ -56,7 +56,7 @@ func CmdShowRevokedNocRootCertificates() *cobra.Command {
5656

5757
cmd := &cobra.Command{
5858
Use: "revoked-noc-x509-root-cert",
59-
Short: "Gets revoked noc root certificates " +
59+
Short: "Gets revoked noc root certificates (RCACs)" +
6060
"by the given combination of subject and subject-key-id",
6161
Args: cobra.ExactArgs(0),
6262
RunE: func(cmd *cobra.Command, args []string) (err error) {

x/pki/client/cli/tx_add_noc_x_509_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func CmdAddNocX509IcaCert() *cobra.Command {
2222
)
2323
cmd := &cobra.Command{
2424
Use: "add-noc-x509-ica-cert",
25-
Short: "Adds NOC non-root certificate",
25+
Short: "Adds NOC non-root certificate (ICAC)",
2626
Args: cobra.ExactArgs(0),
2727
RunE: func(cmd *cobra.Command, args []string) (err error) {
2828
clientCtx, err := client.GetClientTxContext(cmd)

x/pki/client/cli/tx_add_noc_x_509_root_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func CmdAddNocX509RootCert() *cobra.Command {
2121
)
2222
cmd := &cobra.Command{
2323
Use: "add-noc-x509-root-cert",
24-
Short: "Adds NOC root certificate",
24+
Short: "Adds NOC root certificate (RCAC)",
2525
Args: cobra.ExactArgs(0),
2626
RunE: func(cmd *cobra.Command, args []string) (err error) {
2727
clientCtx, err := client.GetClientTxContext(cmd)

x/pki/client/cli/tx_remove_noc_x_509_ica_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var _ = strconv.Itoa(0)
1818
func CmdRemoveNocX509IcaCert() *cobra.Command {
1919
cmd := &cobra.Command{
2020
Use: "remove-noc-x509-ica-cert",
21-
Short: "Removes the given NOC ICA intermediate or leaf certificate.",
21+
Short: "Removes the given NOC ICA intermediate or leaf certificate (ICAC).",
2222
Args: cobra.ExactArgs(0),
2323
RunE: func(cmd *cobra.Command, args []string) (err error) {
2424
clientCtx, err := client.GetClientTxContext(cmd)

x/pki/client/cli/tx_remove_noc_x_509_root_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var _ = strconv.Itoa(0)
1818
func CmdRemoveNocX509RootCert() *cobra.Command {
1919
cmd := &cobra.Command{
2020
Use: "remove-noc-x509-root-cert",
21-
Short: "Removes the given NOC root certificate from the ledger.",
21+
Short: "Removes the given NOC root certificate (RCAC) from the ledger.",
2222
Args: cobra.ExactArgs(0),
2323
RunE: func(cmd *cobra.Command, args []string) (err error) {
2424
clientCtx, err := client.GetClientTxContext(cmd)

x/pki/client/cli/tx_revoke_noc_root_x_509_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var _ = strconv.Itoa(0)
1818
func CmdRevokeNocX509RootCert() *cobra.Command {
1919
cmd := &cobra.Command{
2020
Use: "revoke-noc-x509-root-cert",
21-
Short: "Revokes the given noc root certificate. " +
21+
Short: "Revokes the given noc root certificate (RCAC). " +
2222
"If revoke-child flag is set to true then all the noc certificates in the subtree signed by the revoked " +
2323
"certificate will be revoked as well.",
2424
Args: cobra.ExactArgs(0),

x/pki/client/cli/tx_revoke_noc_x_509_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var _ = strconv.Itoa(0)
1818
func CmdRevokeNocX509IcaCert() *cobra.Command {
1919
cmd := &cobra.Command{
2020
Use: "revoke-noc-x509-ica-cert",
21-
Short: "Revokes the given NOC intermediate or leaf certificate. " +
21+
Short: "Revokes the given NOC intermediate or leaf certificate (ICAC). " +
2222
"If revoke-child flag is set to true then all the certificates in the subtree signed by the revoked " +
2323
"certificate will be revoked as well.",
2424
Args: cobra.ExactArgs(0),

0 commit comments

Comments
 (0)