improvements #566 #570

- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>

Author: Abdulbois

x/model/handler_test.go

@@ -812,6 +812,21 @@ func TestHandler_AddModelVersion(t *testing.T) {
 	require.Equal(t, schemaVersion, receivedModelVersion.SchemaVersion)
 }
 
+func TestHandler_AddModelVersionWithInvalidOtaChecksum(t *testing.T) {
+	setup := Setup(t)
+
+	// add new model
+	msgCreateModel := NewMsgCreateModel(setup.Vendor)
+	_, err := setup.Handler(setup.Ctx, msgCreateModel)
+	require.NoError(t, err)
+
+	// add new model version
+	msgCreateModelVersion := NewMsgCreateModelVersion(setup.Vendor, testconstants.SoftwareVersion)
+	msgCreateModelVersion.OtaChecksum = "not_base64_encoded"
+	_, err = setup.Handler(setup.Ctx, msgCreateModelVersion)
+	require.ErrorIs(t, err, types.ErrOtaChecksumIsNotValid)
+}
+
 func TestHandler_AddMultipleModelVersions(t *testing.T) {
 	setup := Setup(t)
 

x/model/keeper/msg_server_model_version.go

@@ -2,6 +2,7 @@ package keeper
 
 import (
 	"context"
+	"encoding/base64"
 
 	"cosmossdk.io/errors"
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -44,6 +45,11 @@ func (k msgServer) CreateModelVersion(goCtx context.Context, msg *types.MsgCreat
 		return nil, types.NewErrModelVersionAlreadyExists(msg.Vid, msg.Pid, msg.SoftwareVersion)
 	}
 
+	_, err = base64.StdEncoding.DecodeString(msg.OtaChecksum)
+	if err != nil {
+		return nil, types.NewErrOtaChecksumIsNotValid(msg.OtaChecksum)
+	}
+
 	modelVersion := types.ModelVersion{
 		Creator:                      msg.Creator,
 		Vid:                          msg.Vid,