Skip to content

Commit 3fb9d94

Browse files
committed
#535 Add new txn to remove non-root certificates
Fix linter error Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
1 parent 1844e3d commit 3fb9d94

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

integration_tests/cli/pki-remove-x509-certificates.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ response_does_not_contain "$result" "\"serialNumber\": \"$intermediate_cert_1_se
112112
echo "Request all revoked certificates should be empty"
113113
result=$(dcld query pki all-revoked-x509-certs)
114114
echo $result | jq
115-
check_response "$result" "Not Found"
115+
check_response "$result" "\[\]"
116116
response_does_not_contain "$result" "\"subject\": \"$intermediate_cert_subject\""
117117
response_does_not_contain "$result" "\"subjectKeyId\": \"$intermediate_cert_subject_key_id\""
118118
response_does_not_contain "$result" "\"serialNumber\": \"$intermediate_cert_1_serial_number\""

x/pki/keeper/msg_server_remove_x_509_cert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ func (k msgServer) RemoveX509Cert(goCtx context.Context, msg *types.MsgRemoveX50
1414

1515
aprCerts, foundApproved := k.GetApprovedCertificates(ctx, msg.Subject, msg.SubjectKeyId)
1616
revCerts, foundRevoked := k.GetRevokedCertificates(ctx, msg.Subject, msg.SubjectKeyId)
17-
certificates := append(aprCerts.Certs, revCerts.Certs...)
17+
certificates := append(aprCerts.Certs, revCerts.Certs...) //nolint:gocritic
1818
if len(certificates) == 0 {
1919
return nil, pkitypes.NewErrCertificateDoesNotExist(msg.Subject, msg.SubjectKeyId)
2020
}

0 commit comments

Comments
 (0)