Skip to content

Commit 72d80ab

Browse files
committed
#303 Upgrade Cosmos-SDK to v0.47.3
- Fix unit tests - Modify BroadcastTx of grpc integration tests due to cosmos-sdk API changes Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
1 parent e9279cc commit 72d80ab

File tree

2 files changed

+37
-11
lines changed

2 files changed

+37
-11
lines changed

integration_tests/utils/grpc_rest.go

+13-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"bufio"
1919
"context"
2020
"errors"
21+
"fmt"
2122
"os"
2223
"path/filepath"
2324
"testing"
@@ -135,7 +136,7 @@ func (suite *TestSuite) BuildTx(
135136

136137
//nolint:nosnakecase
137138
func (suite *TestSuite) BroadcastTx(txBytes []byte) (*sdk.TxResponse, error) {
138-
var broadcastResp *tx.BroadcastTxResponse
139+
var txResponse *tx.GetTxResponse
139140
var err error
140141

141142
body := tx.BroadcastTxRequest{
@@ -144,7 +145,7 @@ func (suite *TestSuite) BroadcastTx(txBytes []byte) (*sdk.TxResponse, error) {
144145
}
145146

146147
if suite.Rest {
147-
var _resp tx.BroadcastTxResponse
148+
var _resp tx.GetTxResponse
148149

149150
bodyBytes, err := suite.EncodingConfig.Codec.MarshalJSON(&body)
150151
require.NoError(suite.T, err)
@@ -153,22 +154,29 @@ func (suite *TestSuite) BroadcastTx(txBytes []byte) (*sdk.TxResponse, error) {
153154
if err != nil {
154155
return nil, err
155156
}
157+
158+
respBytes, err = SendGetRequest(fmt.Sprintf("/cosmos/tx/v1beta1/txs/%s", _resp.GetTxResponse().TxHash))
156159
require.NoError(suite.T, suite.EncodingConfig.Codec.UnmarshalJSON(respBytes, &_resp))
157-
broadcastResp = &_resp
160+
txResponse = &_resp
158161
} else {
159162
grpcConn := suite.GetGRPCConn()
160163
defer grpcConn.Close()
161164

162165
// Broadcast the tx via gRPC. We create a new client for the Protobuf Tx
163166
// service.
164167
txClient := tx.NewServiceClient(grpcConn)
165-
broadcastResp, err = txClient.BroadcastTx(context.Background(), &body)
168+
broadCastResponse, err := txClient.BroadcastTx(context.Background(), &body)
169+
if err != nil {
170+
return nil, err
171+
}
172+
173+
txResponse, err = txClient.GetTx(context.Background(), &tx.GetTxRequest{Hash: broadCastResponse.GetTxResponse().TxHash})
166174
if err != nil {
167175
return nil, err
168176
}
169177
}
170178

171-
resp := broadcastResp.TxResponse
179+
resp := txResponse.TxResponse
172180
if resp.Code != 0 {
173181
err = sdkerrors.ABCIError(resp.Codespace, resp.Code, resp.RawLog)
174182

x/model/client/cli/tx_model_test.go

+24-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ import (
66
"testing"
77

88
"github.com/cosmos/cosmos-sdk/client/flags"
9+
authtx "github.com/cosmos/cosmos-sdk/x/auth/tx"
910
"github.com/stretchr/testify/require"
11+
1012
testconstants "github.com/zigbee-alliance/distributed-compliance-ledger/integration_tests/constants"
1113
testcli "github.com/zigbee-alliance/distributed-compliance-ledger/testutil/cli"
1214
"github.com/zigbee-alliance/distributed-compliance-ledger/testutil/network"
@@ -65,9 +67,14 @@ func TestCreateModel(t *testing.T) {
6567
}
6668
args = append(args, fields...)
6769
args = append(args, common...)
68-
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
70+
txResp, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
71+
require.NoError(t, err)
72+
err = net.WaitForNextBlock()
73+
require.NoError(t, err)
6974
if tc.err != nil {
70-
require.ErrorIs(t, err, tc.err)
75+
resp, err := authtx.QueryTx(ctx, txResp.TxHash)
76+
require.NoError(t, err)
77+
require.Contains(t, resp.RawLog, tc.err.Error())
7178
} else {
7279
require.NoError(t, err)
7380
}
@@ -107,6 +114,8 @@ func TestUpdateModel(t *testing.T) {
107114
args = append(args, common...)
108115
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
109116
require.NoError(t, err)
117+
err = net.WaitForNextBlock()
118+
require.NoError(t, err)
110119

111120
fields := []string{
112121
fmt.Sprintf("--%s=%v", cli.FlagProductName, testconstants.ProductName) + "-updated",
@@ -150,9 +159,12 @@ func TestUpdateModel(t *testing.T) {
150159
}
151160
args = append(args, fields...)
152161
args = append(args, common...)
153-
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdUpdateModel(), args)
162+
txResp, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdUpdateModel(), args)
163+
err = net.WaitForNextBlock()
154164
if tc.err != nil {
155-
require.ErrorIs(t, err, tc.err)
165+
resp, err := authtx.QueryTx(ctx, txResp.TxHash)
166+
require.NoError(t, err)
167+
require.Contains(t, resp.RawLog, tc.err.Error())
156168
} else {
157169
require.NoError(t, err)
158170
}
@@ -193,6 +205,8 @@ func TestDeleteModel(t *testing.T) {
193205
args = append(args, common...)
194206
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
195207
require.NoError(t, err)
208+
err = net.WaitForNextBlock()
209+
require.NoError(t, err)
196210

197211
for _, tc := range []struct {
198212
desc string
@@ -221,9 +235,13 @@ func TestDeleteModel(t *testing.T) {
221235
fmt.Sprintf("--%s=%v", cli.FlagPid, tc.idPid),
222236
}
223237
args = append(args, common...)
224-
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdDeleteModel(), args)
238+
txResp, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdDeleteModel(), args)
239+
waitErr := net.WaitForNextBlock()
240+
require.NoError(t, waitErr)
225241
if tc.err != nil {
226-
require.ErrorIs(t, err, tc.err)
242+
resp, err := authtx.QueryTx(ctx, txResp.TxHash)
243+
require.NoError(t, err)
244+
require.Contains(t, resp.RawLog, tc.err.Error())
227245
} else {
228246
require.NoError(t, err)
229247
}

0 commit comments

Comments
 (0)