Skip to content

Commit c9cb99b

Browse files
committed
#524 Enable removing NOC root certificates
Refactor impl Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
1 parent 9d29610 commit c9cb99b

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

x/pki/keeper/msg_server_remove_noc_x_509_root_cert.go

+2-12
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ func (k msgServer) RemoveNocX509RootCert(goCtx context.Context, msg *types.MsgRe
5555
k.removeApprovedX509Cert(ctx, certID, &aprCerts, msg.SerialNumber)
5656

5757
// Remove from NOC lists
58-
removeCertFromList(certBySerialNumber.Issuer, certBySerialNumber.SerialNumber, &nocCerts.Certs)
59-
k._removeNocX509RootCert(ctx, certID, &nocCerts, msg.SerialNumber)
58+
k.RemoveNocRootCertificateBySerialNumber(ctx, nocCerts.Vid, certID.Subject, certID.SubjectKeyId, msg.SerialNumber)
59+
k.RemoveNocRootCertificateByVidSubjectSkidAndSerialNumber(ctx, nocCerts.Vid, certID.Subject, certID.SubjectKeyId, msg.SerialNumber)
6060
}
6161

6262
if foundRevoked {
@@ -86,16 +86,6 @@ func (k msgServer) RemoveNocX509RootCert(goCtx context.Context, msg *types.MsgRe
8686
return &types.MsgRemoveNocX509RootCertResponse{}, nil
8787
}
8888

89-
func (k msgServer) _removeNocX509RootCert(ctx sdk.Context, certID types.CertificateIdentifier, certificates *types.NocRootCertificatesByVidAndSkid, serialNumber string) {
90-
if len(certificates.Certs) == 0 {
91-
k.RemoveNocRootCertificate(ctx, certificates.Vid, certID.Subject, certID.SubjectKeyId)
92-
k.RemoveNocRootCertificatesByVidAndSkid(ctx, certificates.Vid, certID.SubjectKeyId)
93-
} else {
94-
k.RemoveNocRootCertificateBySerialNumber(ctx, certificates.Vid, certID.Subject, certID.SubjectKeyId, serialNumber)
95-
k.RemoveNocRootCertificateByVidSubjectSkidAndSerialNumber(ctx, certificates.Vid, certID.Subject, certID.SubjectKeyId, serialNumber)
96-
}
97-
}
98-
9989
func (k msgServer) _removeRevokedNocX509RootCert(ctx sdk.Context, certID types.CertificateIdentifier, certificates *types.RevokedNocRootCertificates) {
10090
if len(certificates.Certs) == 0 {
10191
k.RemoveRevokedNocRootCertificates(ctx, certID.Subject, certID.SubjectKeyId)

0 commit comments

Comments
 (0)