Skip to content

Commit f0b559f

Browse files
committed
#303 Upgrade Cosmos-SDK to v0.47.3
- Fix unit tests - Modify BroadcastTx of grpc integration tests due to cosmos-sdk API changes Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
1 parent e9279cc commit f0b559f

File tree

2 files changed

+40
-12
lines changed

2 files changed

+40
-12
lines changed

integration_tests/utils/grpc_rest.go

+15-6
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"bufio"
1919
"context"
2020
"errors"
21+
"fmt"
2122
"os"
2223
"path/filepath"
2324
"testing"
@@ -135,7 +136,7 @@ func (suite *TestSuite) BuildTx(
135136

136137
//nolint:nosnakecase
137138
func (suite *TestSuite) BroadcastTx(txBytes []byte) (*sdk.TxResponse, error) {
138-
var broadcastResp *tx.BroadcastTxResponse
139+
var txResponse *tx.GetTxResponse
139140
var err error
140141

141142
body := tx.BroadcastTxRequest{
@@ -144,31 +145,39 @@ func (suite *TestSuite) BroadcastTx(txBytes []byte) (*sdk.TxResponse, error) {
144145
}
145146

146147
if suite.Rest {
147-
var _resp tx.BroadcastTxResponse
148+
var _resp tx.GetTxResponse
148149

149150
bodyBytes, err := suite.EncodingConfig.Codec.MarshalJSON(&body)
150151
require.NoError(suite.T, err)
151152

152-
respBytes, err := SendPostRequest("/cosmos/tx/v1beta1/txs", bodyBytes, "", "")
153+
_, err = SendPostRequest("/cosmos/tx/v1beta1/txs", bodyBytes, "", "")
153154
if err != nil {
154155
return nil, err
155156
}
157+
158+
respBytes, err := SendGetRequest(fmt.Sprintf("/cosmos/tx/v1beta1/txs/%s", _resp.GetTxResponse().TxHash))
159+
require.NoError(suite.T, err)
156160
require.NoError(suite.T, suite.EncodingConfig.Codec.UnmarshalJSON(respBytes, &_resp))
157-
broadcastResp = &_resp
161+
txResponse = &_resp
158162
} else {
159163
grpcConn := suite.GetGRPCConn()
160164
defer grpcConn.Close()
161165

162166
// Broadcast the tx via gRPC. We create a new client for the Protobuf Tx
163167
// service.
164168
txClient := tx.NewServiceClient(grpcConn)
165-
broadcastResp, err = txClient.BroadcastTx(context.Background(), &body)
169+
broadCastResponse, err := txClient.BroadcastTx(context.Background(), &body)
170+
if err != nil {
171+
return nil, err
172+
}
173+
174+
txResponse, err = txClient.GetTx(context.Background(), &tx.GetTxRequest{Hash: broadCastResponse.GetTxResponse().TxHash})
166175
if err != nil {
167176
return nil, err
168177
}
169178
}
170179

171-
resp := broadcastResp.TxResponse
180+
resp := txResponse.TxResponse
172181
if resp.Code != 0 {
173182
err = sdkerrors.ABCIError(resp.Codespace, resp.Code, resp.RawLog)
174183

x/model/client/cli/tx_model_test.go

+25-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ import (
66
"testing"
77

88
"github.com/cosmos/cosmos-sdk/client/flags"
9+
authtx "github.com/cosmos/cosmos-sdk/x/auth/tx"
910
"github.com/stretchr/testify/require"
11+
1012
testconstants "github.com/zigbee-alliance/distributed-compliance-ledger/integration_tests/constants"
1113
testcli "github.com/zigbee-alliance/distributed-compliance-ledger/testutil/cli"
1214
"github.com/zigbee-alliance/distributed-compliance-ledger/testutil/network"
@@ -65,9 +67,14 @@ func TestCreateModel(t *testing.T) {
6567
}
6668
args = append(args, fields...)
6769
args = append(args, common...)
68-
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
70+
txResp, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
71+
require.NoError(t, err)
72+
err = net.WaitForNextBlock()
73+
require.NoError(t, err)
6974
if tc.err != nil {
70-
require.ErrorIs(t, err, tc.err)
75+
resp, err := authtx.QueryTx(ctx, txResp.TxHash)
76+
require.NoError(t, err)
77+
require.Contains(t, resp.RawLog, tc.err.Error())
7178
} else {
7279
require.NoError(t, err)
7380
}
@@ -107,6 +114,8 @@ func TestUpdateModel(t *testing.T) {
107114
args = append(args, common...)
108115
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
109116
require.NoError(t, err)
117+
err = net.WaitForNextBlock()
118+
require.NoError(t, err)
110119

111120
fields := []string{
112121
fmt.Sprintf("--%s=%v", cli.FlagProductName, testconstants.ProductName) + "-updated",
@@ -150,9 +159,13 @@ func TestUpdateModel(t *testing.T) {
150159
}
151160
args = append(args, fields...)
152161
args = append(args, common...)
153-
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdUpdateModel(), args)
162+
txResp, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdUpdateModel(), args)
163+
require.NoError(t, err)
164+
err = net.WaitForNextBlock()
154165
if tc.err != nil {
155-
require.ErrorIs(t, err, tc.err)
166+
resp, err := authtx.QueryTx(ctx, txResp.TxHash)
167+
require.NoError(t, err)
168+
require.Contains(t, resp.RawLog, tc.err.Error())
156169
} else {
157170
require.NoError(t, err)
158171
}
@@ -193,6 +206,8 @@ func TestDeleteModel(t *testing.T) {
193206
args = append(args, common...)
194207
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdCreateModel(), args)
195208
require.NoError(t, err)
209+
err = net.WaitForNextBlock()
210+
require.NoError(t, err)
196211

197212
for _, tc := range []struct {
198213
desc string
@@ -221,9 +236,13 @@ func TestDeleteModel(t *testing.T) {
221236
fmt.Sprintf("--%s=%v", cli.FlagPid, tc.idPid),
222237
}
223238
args = append(args, common...)
224-
_, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdDeleteModel(), args)
239+
txResp, err := testcli.ExecTestCLITxCmd(t, ctx, cli.CmdDeleteModel(), args)
240+
waitErr := net.WaitForNextBlock()
241+
require.NoError(t, waitErr)
225242
if tc.err != nil {
226-
require.ErrorIs(t, err, tc.err)
243+
resp, err := authtx.QueryTx(ctx, txResp.TxHash)
244+
require.NoError(t, err)
245+
require.Contains(t, resp.RawLog, tc.err.Error())
227246
} else {
228247
require.NoError(t, err)
229248
}

0 commit comments

Comments
 (0)