Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Certify model] Change validation for available min and max values for the certification-date field. #8

Open
julia-aksyanova opened this issue Sep 3, 2020 · 0 comments

Comments

@julia-aksyanova
Copy link
Collaborator

Severity:
enhancement

Build info:
0505970

Overview:
Need to add the limitation for the certification-date field in the certify-model command (zblcli tx compliance certify-model --vid=<uint16> --pid=<uint16> --certification-type=<zb> --certification-date=<rfc3339 encoded date> --from=<account>).
Actually, the test-date field has the following limits:

  • minimum available value is equal to 1000-01-01T00:00:00Z;
  • maximum available value is equal to 9999-12-31T23:59:59Z.

It is suggested to change these limitations for the following values that must be discussed:

  • minimum available value is equal to 1900-01-01T00:00:00Z;
  • maximum available value is equal to 1999-12-31T23:59:59Z.

Also, maybe it will be better to add the validation that the entered value for the certification-date parameter is not from the future.
certification-date parameter should have the date from the past. So the user should not have any possibility to add a date from the future (tomorrow, next week/year/century, etc.).
And this remark can affect the suggestion above (maximum available value is equal to 1999-12-31T23:59:59Z.).

@ashcherbakov ashcherbakov added this to the v0.3 milestone Sep 10, 2020
@ashcherbakov ashcherbakov removed this from the v0.3 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants