Skip to content

Commit 19ec4a5

Browse files
authored
tools: clone proto files from spec (tendermint#6976)
## Description clone proto files from spec in order to have them in a single location closes tendermint/spec#343
1 parent ca8f004 commit 19ec4a5

17 files changed

+31
-993
lines changed

CHANGELOG_PENDING.md

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Special thanks to external contributors on this release:
1515
- [rpc] Remove the deprecated gRPC interface to the RPC service (@creachadair).
1616

1717
- Apps
18+
- [proto/tendermint] \#6976 Remove core protobuf files in favor of only housing them in the [tendermint/spec](https://github.com/tendermint/spec) repository.
1819

1920
- P2P Protocol
2021

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ We use [Protocol Buffers](https://developers.google.com/protocol-buffers) along
109109

110110
For linting, checking breaking changes and generating proto stubs, we use [buf](https://buf.build/). If you would like to run linting and check if the changes you have made are breaking then you will need to have docker running locally. Then the linting cmd will be `make proto-lint` and the breaking changes check will be `make proto-check-breaking`.
111111

112-
We use [Docker](https://www.docker.com/) to generate the protobuf stubs. To generate the stubs yourself, make sure docker is running then run `make proto-gen`.
112+
We use [Docker](https://www.docker.com/) to generate the protobuf stubs. To generate the stubs yourself, make sure docker is running then run `make proto-gen`. This command uses the spec repo to get the necessary protobuf files for generating the go code. If you are modifying the proto files manually for changes in the core data structures, you will need to clone them into the go repo and comment out lines 22-37 of the file `./scripts/protocgen.sh`.
113113

114114
### Visual Studio Code
115115

abci/types/types.pb.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/tendermint/abci/types.proto

-369
This file was deleted.

0 commit comments

Comments
 (0)