forked from kedacore/keda
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade keda #5
Open
pratishbodhale
wants to merge
391
commits into
main
Choose a base branch
from
upgrade-keda
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade keda #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect Validations (kedacore#5377) KEDA admission webhook rejects ScaledObject requests with CPU or memory triggers when the resource limits (CPU/memory based on triggers) are not set in the pod spec. This is expected behavior. But if default limits are set in the LimitRange object in the same namespace, the admission webhook should allow the ScaledObject request, which currently doesn’t. This change will check if there is a LimitRange with default limits (CPU/memory based on triggers) in the namespace that ScaledObject is in, and allows the request to proceed. Also, added RBAC permissions for list & watch LimitRange. Updated Change Log. Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
…5402) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
…re#5410) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Set LeaderElectionNamespace to PodNamespace Signed-off-by: Ali Aqel <aliaqel@stripe.com> * update changelog Signed-off-by: Ali Aqel <aliaqel@stripe.com> * move changelog to unreleased Signed-off-by: Ali Aqel <aliaqel@stripe.com> * fix changelog Signed-off-by: Ali Aqel <aliaqel@stripe.com> * fix changelog ordering Signed-off-by: Ali Aqel <aliaqel@stripe.com> * fix changelog per comments Signed-off-by: Ali Aqel <aliaqel@stripe.com> --------- Signed-off-by: Ali Aqel <aliaqel@stripe.com>
…e#5421) Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
…re#5427) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Yoon Park <yoongon.park@gmail.com>
* Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
…ok (kedacore#5403) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
* chore: bump deps Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update manifests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
…re#5485) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
…s and properly close the connecctions (kedacore#5452) * fix(gcp scalers): Restore previous time horizon to fix missing metrics Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Close gcp client on scaler closing Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
* add grpc authority head override command-line flag Signed-off-by: Ali Aqel <aliaqel@stripe.com> Signed-off-by: aliaqel-stripe <120822631+aliaqel-stripe@users.noreply.github.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: googs1025 <googs1025@gmail.com>
…edacore#5518) Signed-off-by: Vinod Kumar Nair <vinod827@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: June Han <sorrowitsch@gmail.com>
…e#5433) Signed-off-by: atilsensalduz <atil.eren@outlook.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
| datasource | package | from | to | | ----------- | ------------- | ------ | ------ | | github-tags | actions/cache | v4.0.0 | v4.0.1 | Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… creation (kedacore#5524) Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
…riggerAuthentication (kedacore#5517) Signed-off-by: Paul Yu <paul.d.yu@gmail.com> Signed-off-by: Paul Yu <pauyu@microsoft.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
* Refactor couchdb scaler Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Update Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
* Refactor cassandra scaler Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * Update feedback Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: wangrushen <wrs369@88.com>
* Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGLOG Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge_turrado@hotmail.es>
…edacore#6285) Signed-off-by: Ruben Herrebrugh <raherrebrugh@gmail.com>
* add error checking for sqs metrics to avoid runtime panics Signed-off-by: Rob Pickerill <r.pickerill@gmail.com> * update changelog Signed-off-by: Rob Pickerill <r.pickerill@gmail.com> --------- Signed-off-by: Rob Pickerill <r.pickerill@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
…rbs (kedacore#6129) * fix: Replace wildcards in RBAC objects with explicit resources and verbs Signed-off-by: Mikhail Zholobov <legal90@gmail.com> * Update changelog Signed-off-by: Mikhail Zholobov <legal90@gmail.com> * Revert the deletion of RBAC rule "allow to get any resource" Signed-off-by: Mikhail Zholobov <legal90@gmail.com> * Rollback the RBAC rule for "*/scale" According to the PR review comment. Signed-off-by: Mikhail Zholobov <legal90@gmail.com> --------- Signed-off-by: Mikhail Zholobov <legal90@gmail.com>
* Refactor Selenium Grid scaler Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Add unit tests from other PRs Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
* Refactor azure queue scaler Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> * update after feedback Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> --------- Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com> Signed-off-by: sbarnesthornton <56411235+sbarnesthornton@users.noreply.github.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Sam Barnes-Thornton <sbt@netcraft.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
…kedacore#6251) Signed-off-by: Leevi Lehtonen <leevi.k.lehtonen@gmail.com>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
…`dimensionValue` lists (kedacore#6313)
Co-authored-by: SpiritZhou <iammrzhouzhenghanzhou@gmail.com>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
…estart (kedacore#6322) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>
* feat: add nsq scaler Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * fix changelog and image ref Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * fix changelog formatting Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * fix: address comments Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * feat: add useHttps/unsafeSsl to nsqScaler Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * fix: make nsq e2e tests more reliable Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * Update tests/scalers/nsq/nsq_test.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> * fix: update changelog Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> --------- Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in kedacore#5916 Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
c524d54
to
8a3fe59
Compare
8a3fe59
to
a7fece9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.