Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cypress init #17

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Feat/cypress init #17

merged 3 commits into from
Feb 4, 2024

Conversation

dsstevens
Copy link
Contributor

@dsstevens dsstevens commented Feb 3, 2024

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Small fix (Corrected a typo, removed a comment, etc.)

Issue/feature/bug description:

Added Cypress for testing, reverted the package.json script command to "react-scripts test" from the previous work-around to build and deploy on Vercel.
Update
Still not working with the test scripts, will add the skipping test command now

Checklist before requesting a review

  • I ran the code locally and verified that there are no visible errors.
  • I have performed a self-review of my code
  • I have refactored my code before this push
  • The commit message follows our guidelines
  • My code follows the code style of this project.

What’s next:

Functionality!!! Refining the leaflet map, fleshing out components for the app, verifying that Cypress is working with the package.json command for tests

@dsstevens dsstevens added the enhancement New feature or request label Feb 3, 2024
@dsstevens dsstevens requested a review from rsteckline February 3, 2024 23:24
@dsstevens dsstevens self-assigned this Feb 3, 2024
Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laboulangerie ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 11:31pm

This was linked to issues Feb 3, 2024
Copy link
Contributor

@rsteckline rsteckline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get testing 💪

@rsteckline rsteckline merged commit 7882a9c into main Feb 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE- Add Cypress Initial setup deliverables
2 participants