Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api integration #28

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Feat/api integration #28

merged 7 commits into from
Feb 6, 2024

Conversation

rsteckline
Copy link
Contributor

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Small fix (Corrected a typo, removed a comment, etc.)

Feature description:

Adds a breadlist page for each country when clicked.

  • May need to edit info, pages have differing info. Names ending with bread, "bread" on top of France.

Checklist before requesting a review

  • I ran the code locally and verified that there are no visible errors.
  • I have performed a self-review of my code
  • I have refactored my code before this push
  • The commit message follows our guidelines
  • My code follows the code style of this project.

What’s next:

Work on styling and details page

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laboulangerie ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 9:59pm

Copy link
Contributor

@dsstevens dsstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we had discussed on a call, this fetch is now working after resolving a CORS issue. We also learned that unnecessary imports don't affect production and deployment even if the CI GA check doesn't pass. The data is coming thru great so we just need to clean up the format so it's all consistent.

@dsstevens dsstevens merged commit bd60845 into main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: User story: when I click a region, I see a list of bread types as a dropdown menu of buttons
3 participants