Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cypress refactor #40

Merged
merged 10 commits into from
Feb 10, 2024
Merged

Feat/cypress refactor #40

merged 10 commits into from
Feb 10, 2024

Conversation

rsteckline
Copy link
Contributor

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Small fix (Corrected a typo, removed a comment, etc.)

Issue/feature/bug description:

  • Refactor the tests to align with new API response structure
  • Refactor the error handling
  • Implement working tests

Checklist before requesting a review

  • I ran the code locally and verified that there are no visible errors.
  • I have performed a self-review of my code
  • I have refactored my code before this push
  • The commit message follows our guidelines
  • My code follows the code style of this project.

What’s next:

Finalize styling!

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laboulangerie ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 10:58pm

Copy link
Contributor

@dsstevens dsstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We combined some small CSS tweaks with the styling branch and for the sake of time also put code cleanup on here as well. We were working sync and tag-teamed this work so happy with the results.

@dsstevens dsstevens merged commit a63045c into main Feb 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants