-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15 tk 016create page to enter sms otp #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NkwaTambe
requested review from
Koufan-De-King,
stephane-segning,
Elwizzy12,
Arielpetit,
Christiantyemele,
nancymuyeh and
yvanhenang
October 21, 2024 14:40
Arielpetit
reviewed
Oct 22, 2024
Arielpetit
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a test is missing, Please do well to add it
Arielpetit
approved these changes
Oct 23, 2024
Arielpetit
requested changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Create SMS OTP Entry Page
Documentation Impl : https://dominicarrojado.com/posts/how-to-create-your-own-otp-input-in-react-and-typescript-with-tests-part-1/
Documentation Test : https://dominicarrojado.com/posts/how-to-create-your-own-otp-input-in-react-and-typescript-with-tests-part-2/
Description:
This pull request introduces a new page for users to enter their SMS-based One-Time Password (OTP) during the authentication process. The implementation includes:
An intuitive layout with input fields for a 4-digit OTP.
Automatic focus management between input fields for enhanced user experience.
Validation to ensure only numeric input is accepted.
A resend OTP feature for user convenience.