Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reflect notch size padding #234

Merged
merged 5 commits into from
Oct 24, 2024
Merged

fix: reflect notch size padding #234

merged 5 commits into from
Oct 24, 2024

Conversation

ojj1123
Copy link
Contributor

@ojj1123 ojj1123 commented Oct 24, 2024 •
edited
Loading

PR points

  • useKeypadHeight 를 통해 키패드 여부에 따라 iphone 노치 사이즈 반영
  • AS-IS와 같이 밑에 빈 공간이 생겨 marginBottom 말고 paddingBottom으로 수정
AS-IS TO-BE
밑 빈공간 제거

@ojj1123 ojj1123 requested a review from SeungJL October 24, 2024 14:14
@ojj1123 ojj1123 self-assigned this Oct 24, 2024
@SeungJL SeungJL merged commit d94c62d into main Oct 24, 2024
2 of 5 checks passed
@ojj1123 ojj1123 deleted the fix/square-input-style branch October 24, 2024 16:09
SeungJL pushed a commit that referenced this pull request Oct 27, 2024
@ojj1123 @SeungJL
fix: reflect notch size padding (#234)
2295aad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeungJL SeungJL Awaiting requested review from SeungJL

Assignees

@ojj1123 ojj1123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojj1123 @SeungJL