Skip to content

AIK-4442 Report blocked requests per IPList/Botlist #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

AIK-4442 Report blocked requests per IPList/Botlist #166

wants to merge 41 commits into from
+845 −169

Conversation

bitterpanda63
Copy link
Member

@bitterpanda63 bitterpanda63 commented Apr 28, 2025 •
edited
Loading

This will add support for a new feature where we check the usefulness of blocking lists by counting "monitored" requests. This also counts blocked requests to keep monitoring your site.

https://aikido.atlassian.net/browse/AIK-4442

@bitterpanda63
Create new FirewallListsRecord to store blocked and total
9a6293d
@bitterpanda63
Reformat the Statistics object, adding ipAddresses and userAgents
7094ac5
@bitterpanda63
stats: merge total/blocked funcs for iplists/ua's
ba1dcd1
@bitterpanda63
Add ip lists/ua's to StatisticsStore
0dd1b84
@bitterpanda63
Add new StatisticsStore test cases & fix broken heartbeat test
ffecb7b
@bitterpanda63
Add ipAddreses and userAgents stats to clear() in Statistics.java
67ca96c
@bitterpanda63
Change FirewallListsRecord to use new format
ce63c4d
@bitterpanda63
Update test cases with new tests
da5f113
@bitterpanda63
Update reporting api
9af073d
@bitterpanda63
Revert "Update reporting api"
488bdc4 
This reverts commit 9af073d.
@bitterpanda63
Update API call that fetches firewall lists
9bb2f8f
@bitterpanda63
Merge branch 'fix-mutex-mistake-ip-lists' into AIK-4442
9c016b1
@bitterpanda63
Store the response in a special ParsedFirewallLists object
41a5610
@bitterpanda63
WebRequestCollector run all scans
bdaf3bf
@bitterpanda63 bitterpanda63 added enhancement New feature or request WIP Work In Progress labels Apr 28, 2025
@bitterpanda63 bitterpanda63 self-assigned this Apr 28, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.03797% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...age/service_configuration/ParsedFirewallLists.java 90.36% 4 Missing and 4 partials ⚠️
...kido/agent_api/collectors/WebRequestCollector.java 90.47% 1 Missing and 1 partial ⚠️
...aikido/agent_api/storage/ServiceConfiguration.java 92.85% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@bitterpanda63 bitterpanda63 marked this pull request as ready for review April 30, 2025 13:26
@bitterpanda63 bitterpanda63 removed the WIP Work In Progress label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bitterpanda63 bitterpanda63

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitterpanda63